From: Will Deacon <will.deacon@arm.com>
To: Chintan Pandya <cpandya@codeaurora.org>
Cc: catalin.marinas@arm.com, mark.rutland@arm.com,
akpm@linux-foundation.org, toshi.kani@hpe.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v12 4/5] arm64: Implement page table free interfaces
Date: Mon, 4 Jun 2018 16:07:10 +0100 [thread overview]
Message-ID: <20180604150709.GA8593@arm.com> (raw)
In-Reply-To: <98ef3cd0-a9a1-d5b5-f1a6-c0ab8b15ec6a@codeaurora.org>
On Mon, Jun 04, 2018 at 07:13:18PM +0530, Chintan Pandya wrote:
> On 6/4/2018 5:43 PM, Will Deacon wrote:
> >On Fri, Jun 01, 2018 at 06:09:17PM +0530, Chintan Pandya wrote:
> >>+ next = addr;
> >>+ end = addr + PUD_SIZE;
> >>+ do {
> >>+ pmd_free_pte_page(entry, next);
> >>+ } while (entry++, next += PMD_SIZE, next != end);
> >>+
> >>+ pud_clear(pudp);
> >>+ __flush_tlb_kernel_pgtable(addr);
> >>+ pmd_free(NULL, table);
> >>+ }
> >>+ return 1;
> >
> >So with these patches, we only ever return 1 from these helpers. It looks
> >like the same is true for x86, so how about we make them void and move the
> >calls inside the conditionals in lib/ioremap.c? Obviously, this would be a
> >separate patch on the end.
>
> That sounds valid code churn to me. But since x86 discussion is not
> concluded yet, I would wait to share until that gets resolved. May be
> not in v13 but separate effort. Would that be okay to you ?
Yes, fine by me.
Will
next prev parent reply other threads:[~2018-06-04 15:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 12:39 [PATCH v12 0/5] Fix issues with huge mapping in ioremap for ARM64 Chintan Pandya
2018-06-01 12:39 ` [PATCH v12 1/5] ioremap: Update pgtable free interfaces with addr Chintan Pandya
2018-06-01 12:39 ` [PATCH v12 2/5] arm64: tlbflush: Introduce __flush_tlb_kernel_pgtable Chintan Pandya
2018-06-01 12:39 ` [PATCH v12 3/5] arm64: pgtable: Add p*d_page_vaddr helper macros Chintan Pandya
2018-06-04 12:13 ` Will Deacon
2018-06-04 13:43 ` Chintan Pandya
2018-06-04 15:10 ` Will Deacon
2018-06-01 12:39 ` [PATCH v12 4/5] arm64: Implement page table free interfaces Chintan Pandya
2018-06-04 12:13 ` Will Deacon
2018-06-04 13:43 ` Chintan Pandya
2018-06-04 15:07 ` Will Deacon [this message]
2018-06-01 12:39 ` [PATCH v12 5/5] arm64: Allow huge io mappings again Chintan Pandya
2018-06-04 12:14 ` Will Deacon
2018-06-04 13:42 ` Chintan Pandya
2018-06-04 5:56 ` [PATCH v12 0/5] Fix issues with huge mapping in ioremap for ARM64 Chintan Pandya
2018-06-04 10:33 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180604150709.GA8593@arm.com \
--to=will.deacon@arm.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=cpandya@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=toshi.kani@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).