From: Steven Rostedt <rostedt@goodmis.org>
To: Petr Mladek <pmladek@suse.com>
Cc: Maninder Singh <maninder1.s@samsung.com>,
sergey.senozhatsky@gmail.com, linux-kernel@vger.kernel.org,
a.sahrawat@samsung.com, pankaj.m@samsung.com,
v.narang@samsung.com
Subject: Re: [PATCH 1/2] printk: remove unused flag LOG_NOCONS
Date: Mon, 4 Jun 2018 17:33:42 -0400 [thread overview]
Message-ID: <20180604173342.0b7a78e6@gandalf.local.home> (raw)
In-Reply-To: <20180531121633.acuffu2b66q24c5c@pathway.suse.cz>
On Thu, 31 May 2018 14:16:33 +0200
Petr Mladek <pmladek@suse.com> wrote:
> > enum log_flags {
> > - LOG_NOCONS = 1, /* already flushed, do not print to console */
> > - LOG_NEWLINE = 2, /* text ended with a newline */
> > - LOG_PREFIX = 4, /* text started with a prefix */
> > - LOG_CONT = 8, /* text is a fragment of a continuation line */
> > + LOG_NEWLINE = 1, /* text ended with a newline */
> > + LOG_PREFIX = 2, /* text started with a prefix */
> > + LOG_CONT = 4, /* text is a fragment of a continuation line */
> > };
>
> Please, do not renumber the bits if there is no real need for it.
> The format of the log buffer is read also by external tool like
> "crash". It seems that "crash" ignores these flags but...
Then what's the problem for renumbering? I've renumbered internal flags
before. No one complained about it.
-- Steve
next prev parent reply other threads:[~2018-06-04 21:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180531102133epcas5p2e8d47887c1708836c9b70964983093e2@epcas5p2.samsung.com>
2018-05-31 10:17 ` [PATCH 1/2] printk: remove unused flag LOG_NOCONS Maninder Singh
2018-05-31 10:54 ` Sergey Senozhatsky
2018-05-31 12:16 ` Petr Mladek
2018-05-31 15:12 ` Joe Perches
2018-06-05 12:59 ` Petr Mladek
2018-06-04 21:33 ` Steven Rostedt [this message]
2018-06-05 12:56 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180604173342.0b7a78e6@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=a.sahrawat@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maninder1.s@samsung.com \
--cc=pankaj.m@samsung.com \
--cc=pmladek@suse.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=v.narang@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).