From: Thomas Bogendoerfer <tbogendoerfer@suse.de>
To: Paul Burton <paul.burton@mips.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
James Hogan <jhogan@kernel.org>, <linux-mips@linux-mips.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] Make elf2ecoff work on 64bit host machines
Date: Tue, 5 Jun 2018 11:57:21 +0200 [thread overview]
Message-ID: <20180605115721.a61f503af000e9c2b6ad1073@suse.de> (raw)
In-Reply-To: <20180604221404.u55nor4sad6cfamb@pburton-laptop>
On Mon, 4 Jun 2018 15:14:04 -0700
Paul Burton <paul.burton@mips.com> wrote:
> > +#include <stdint.h>
>
> Could you move the #include <stdint.h> into ecoff.h? Since ecoff.h
> itself makes use of these types. I know the end result will be the same,
> but if anything else were ever to include ecoff.h then having the right
> includes there could make that easier.
as elf2ecoff.c uses these types, too, I'll leave the include and add an
additional one in ecoff.h.
> > printf
> > - ("Section %d: %s phys %lx size %lx file offset %lx\n",
> > + ("Section %d: %s phys %"PRIx32" size %"PRIx32" file offset %x\n",
>
> The offset (s_scnptr) format should probably be PRIx32 as well.
correct.
> I know you didn't introduce it but I think the tab before "file" in the
> string would be better represented in source using \t rather than the
> tab character itself, so perhaps you could change that for clarify here
> which would also avoid making the line so long.
ok.
Thomas.
--
SUSE Linux GmbH
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
prev parent reply other threads:[~2018-06-05 9:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-04 8:18 [PATCH v2] Make elf2ecoff work on 64bit host machines Thomas Bogendoerfer
2018-06-04 8:18 ` [PATCH] " Thomas Bogendoerfer
2018-06-04 22:14 ` [PATCH v2] " Paul Burton
2018-06-05 9:57 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180605115721.a61f503af000e9c2b6ad1073@suse.de \
--to=tbogendoerfer@suse.de \
--cc=jhogan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).