From: Kim Phillips <kim.phillips@arm.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Leo Yan <leo.yan@linaro.org>,
Suzuki K Poulose <Suzuki.Poulose@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Alex Williamson <alex.williamson@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Howells <dhowells@redhat.com>,
Eric Auger <eric.auger@redhat.com>,
Eric Biederman <ebiederm@xmission.com>,
Gargi Sharma <gs051095@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Kirill Tkhai <ktkhai@virtuozzo.com>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
Oleg Nesterov <oleg@redhat.com>,
Pavel Tatashin <pasha.tatashin@oracle.com>,
Rik van Riel <riel@redhat.com>,
Robin Murphy <robin.murphy@arm.com>,
Russell King <linux@armlinux.org.uk>,
Thierry Reding <treding@nvidia.com>, Todd Kjos <tkjos@google.com>,
Randy Dunlap <rdunlap@infradead.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kim Phillips <kim.phillips@arm.com>
Subject: [PATCH v4 02/14] coresight: use IS_ENABLED for CONFIGs that may be modules
Date: Tue, 5 Jun 2018 16:06:58 -0500 [thread overview]
Message-ID: <20180605210710.22227-3-kim.phillips@arm.com> (raw)
In-Reply-To: <20180605210710.22227-1-kim.phillips@arm.com>
Checking for ifdef CONFIG_x fails if CONFIG_x=m. Use IS_ENABLED
that is true for both built-ins and modules, instead. Required
when building coresight components as modules.
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Randy Dunlap <rdunlap@infradead.org>
Cc: Suzuki K Poulose <Suzuki.Poulose@arm.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Russell King <linux@armlinux.org.uk>
Signed-off-by: Kim Phillips <kim.phillips@arm.com>
---
drivers/hwtracing/coresight/coresight-etm-perf.h | 2 +-
drivers/hwtracing/coresight/coresight-priv.h | 2 +-
include/linux/coresight.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.h b/drivers/hwtracing/coresight/coresight-etm-perf.h
index 4197df4faf5e..539b250df455 100644
--- a/drivers/hwtracing/coresight/coresight-etm-perf.h
+++ b/drivers/hwtracing/coresight/coresight-etm-perf.h
@@ -43,7 +43,7 @@ struct etm_filters {
};
-#ifdef CONFIG_CORESIGHT
+#if IS_ENABLED(CONFIG_CORESIGHT)
int etm_perf_symlink(struct coresight_device *csdev, bool link);
#else
diff --git a/drivers/hwtracing/coresight/coresight-priv.h b/drivers/hwtracing/coresight/coresight-priv.h
index 1a6cf3589866..158c720119dd 100644
--- a/drivers/hwtracing/coresight/coresight-priv.h
+++ b/drivers/hwtracing/coresight/coresight-priv.h
@@ -144,7 +144,7 @@ struct list_head *coresight_build_path(struct coresight_device *csdev,
struct coresight_device *sink);
void coresight_release_path(struct list_head *path);
-#ifdef CONFIG_CORESIGHT_SOURCE_ETM3X
+#if IS_ENABLED(CONFIG_CORESIGHT_SOURCE_ETM3X)
extern int etm_readl_cp14(u32 off, unsigned int *val);
extern int etm_writel_cp14(u32 off, u32 val);
#else
diff --git a/include/linux/coresight.h b/include/linux/coresight.h
index e5421b83e4e6..548fa56b29bd 100644
--- a/include/linux/coresight.h
+++ b/include/linux/coresight.h
@@ -236,7 +236,7 @@ struct coresight_ops {
const struct coresight_ops_source *source_ops;
};
-#ifdef CONFIG_CORESIGHT
+#if IS_ENABLED(CONFIG_CORESIGHT)
extern struct coresight_device *
coresight_register(struct coresight_desc *desc);
extern void coresight_unregister(struct coresight_device *csdev);
--
2.17.0
next prev parent reply other threads:[~2018-06-05 21:07 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 21:06 [PATCH v4 00/14] coresight: allow to build components as modules Kim Phillips
2018-06-05 21:06 ` [PATCH v4 01/14] coresight: cpu_debug: minor module fixups Kim Phillips
2018-06-06 8:25 ` Greg Kroah-Hartman
2018-06-05 21:06 ` Kim Phillips [this message]
2018-06-05 21:06 ` [PATCH v4 03/14] coresight: move shared barrier_pkt[] to coresight_priv.h Kim Phillips
2018-06-06 8:27 ` Greg Kroah-Hartman
2018-06-05 21:07 ` [PATCH v4 04/14] coresight: export coresight_timeout and etm_perf_symlink Kim Phillips
2018-06-05 21:07 ` [PATCH v4 05/14] coresight: get/put module in coresight_build/release_path Kim Phillips
2018-06-05 21:14 ` Suzuki K Poulose
2018-06-06 8:24 ` Greg Kroah-Hartman
2018-06-06 9:46 ` Suzuki K Poulose
2018-06-06 20:55 ` Kim Phillips
2018-06-07 8:34 ` Greg Kroah-Hartman
2018-06-07 9:04 ` Suzuki K Poulose
2018-06-07 9:13 ` Greg Kroah-Hartman
2018-06-07 9:32 ` Suzuki K Poulose
2018-06-07 9:34 ` Suzuki K Poulose
2018-06-07 9:53 ` Greg Kroah-Hartman
2018-06-07 10:07 ` Suzuki K Poulose
2018-06-07 17:13 ` Kim Phillips
2018-06-07 21:10 ` Suzuki K Poulose
2018-06-07 21:40 ` Mathieu Poirier
2018-06-07 21:47 ` Kim Phillips
2018-06-07 21:59 ` Mathieu Poirier
2018-06-08 9:22 ` Suzuki K Poulose
2018-06-07 9:43 ` Suzuki K Poulose
2018-06-05 21:07 ` [PATCH v4 06/14] coresight: allow stm to be built as a module Kim Phillips
2018-06-05 21:07 ` [PATCH v4 07/14] coresight: allow dynamic-replicator " Kim Phillips
2018-06-05 21:07 ` [PATCH v4 08/14] coresight: allow etm3x " Kim Phillips
2018-06-05 21:07 ` [PATCH v4 09/14] coresight: allow etm4x " Kim Phillips
2018-06-05 21:07 ` [PATCH v4 10/14] coresight: allow etb " Kim Phillips
2018-06-05 21:07 ` [PATCH v4 11/14] coresight: allow tpiu " Kim Phillips
2018-06-05 21:07 ` [PATCH v4 12/14] coresight: allow tmc " Kim Phillips
2018-06-05 21:07 ` [PATCH v4 13/14] coresight: allow funnel and replicator drivers to be built as modules Kim Phillips
2018-06-05 21:07 ` [PATCH v4 14/14] coresight: allow the coresight core driver to be built as a module Kim Phillips
2018-06-06 8:33 ` Greg Kroah-Hartman
2018-06-06 9:57 ` Suzuki K Poulose
2018-06-07 21:46 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180605210710.22227-3-kim.phillips@arm.com \
--to=kim.phillips@arm.com \
--cc=Suzuki.Poulose@arm.com \
--cc=akpm@linux-foundation.org \
--cc=alex.williamson@redhat.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=eric.auger@redhat.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=gs051095@gmail.com \
--cc=ktkhai@virtuozzo.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mathieu.poirier@linaro.org \
--cc=oleg@redhat.com \
--cc=pasha.tatashin@oracle.com \
--cc=rdunlap@infradead.org \
--cc=riel@redhat.com \
--cc=robin.murphy@arm.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=tkjos@google.com \
--cc=treding@nvidia.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).