LKML Archive on
 help / color / Atom feed
From: Mathieu Malaterre <>
To: Thomas Gleixner <>
Cc: Mathieu Malaterre <>,
	Babu Moger <>,
Subject: [PATCH] kernel/watchdog: add missing prototypes for weak functions
Date: Wed,  6 Jun 2018 21:42:32 +0200
Message-ID: <> (raw)

In commit 73ce0511c436 ("kernel/watchdog.c: move hardlockup detector to
separate file") two new functions were added ‘watchdog_nmi_enable’ and
‘watchdog_nmi_disable’ the functions were changed from static to weak.
In which case expose the function declarations in header file.

Silence the following gcc warnings:

  kernel/watchdog.c:109:12: warning: no previous prototype for ‘watchdog_nmi_enable’ [-Wmissing-prototypes]
  kernel/watchdog.c:115:13: warning: no previous prototype for ‘watchdog_nmi_disable’ [-Wmissing-prototypes]

Cc: Babu Moger <>
Signed-off-by: Mathieu Malaterre <>
 include/linux/nmi.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/linux/nmi.h b/include/linux/nmi.h
index b8d868d23e79..50d143995338 100644
--- a/include/linux/nmi.h
+++ b/include/linux/nmi.h
@@ -113,6 +113,8 @@ static inline int hardlockup_detector_perf_init(void) { return 0; }
 void watchdog_nmi_stop(void);
 void watchdog_nmi_start(void);
 int watchdog_nmi_probe(void);
+int watchdog_nmi_enable(unsigned int cpu);
+void watchdog_nmi_disable(unsigned int cpu);
  * touch_nmi_watchdog - restart NMI watchdog timeout.

             reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-06 19:42 Mathieu Malaterre [this message]
2018-11-06 20:35 ` Mathieu Malaterre
2018-11-06 22:21 ` [tip:core/urgent] watchdog/core: Add " tip-bot for Mathieu Malaterre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on

Archives are clonable:
	git clone --mirror lkml/git/0.git
	git clone --mirror lkml/git/1.git
	git clone --mirror lkml/git/2.git
	git clone --mirror lkml/git/3.git
	git clone --mirror lkml/git/4.git
	git clone --mirror lkml/git/5.git
	git clone --mirror lkml/git/6.git
	git clone --mirror lkml/git/7.git
	git clone --mirror lkml/git/8.git
	git clone --mirror lkml/git/9.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ \
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone