From: Andrea Parri <andrea.parri@amarulasolutions.com>
To: Sedat Dilek <sedat.dilek@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Nick Desaulniers <ndesaulniers@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-efi@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
the arch/x86 maintainers <x86@kernel.org>,
virtualization@lists.linux-foundation.org, astrachan@google.com,
Manoj Gupta <manojgupta@google.com>,
Greg Hackmann <ghackmann@google.com>,
tstellar@redhat.com, Kees Cook <keescook@google.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Will Deacon <will.deacon@arm.com>,
mawilcox@microsoft.com, David Rientjes <rientjes@google.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Philippe Ombredanne <pombredanne@nexb.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
Steven Rostedt <rostedt@goodmis.org>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
akataria@vmware.com, Brijesh Singh <brijesh.singh@amd.com>,
Cao jin <caoj.fnst@cn.fujitsu.com>,
gregkh <gregkh@linuxfoundation.org>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Juergen Gross <jgross@suse.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Matthias Kaehlcke <mka@chromium.org>,
"Lendacky, Thomas" <thomas.lendacky@amd.com>,
Thiebaud Weksteen <tweek@google.com>,
mjg59@google.com, Joe Perches <joe@perches.com>
Subject: Re: [PATCH v4 1/3] compiler-gcc.h: add gnu_inline to all inline declarations
Date: Fri, 8 Jun 2018 13:28:26 +0200 [thread overview]
Message-ID: <20180608112826.GA7484@andrea> (raw)
In-Reply-To: <CA+icZUXDoeo5ktZZPFcFyLzk3xthM-98N88QJFzesg6t+Vr5cQ@mail.gmail.com>
On Fri, Jun 08, 2018 at 12:04:36PM +0200, Sedat Dilek wrote:
> On Fri, Jun 8, 2018 at 9:59 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Thu, Jun 7, 2018 at 10:49 PM, Nick Desaulniers
> > <ndesaulniers@google.com> wrote:
> >> Functions marked extern inline do not emit an externally visible
> >> function when the gnu89 C standard is used. Some KBUILD Makefiles
> >> overwrite KBUILD_CFLAGS. This is an issue for GCC 5.1+ users as without
> >> an explicit C standard specified, the default is gnu11. Since c99, the
> >> semantics of extern inline have changed such that an externally visible
> >> function is always emitted. This can lead to multiple definition errors
> >> of extern inline functions at link time of compilation units whose build
> >> files have removed an explicit C standard compiler flag for users of GCC
> >> 5.1+ or Clang.
> >>
> >> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
> >> Suggested-by: H. Peter Anvin <hpa@zytor.com>
> >> Suggested-by: Joe Perches <joe@perches.com>
> >
> > I suspect this will break Geert's gcc-4.1.2, which I think doesn't have that
> > attribute yet (4.1.3 or higher have it according to the documentation.
> >
> > It wouldn't be hard to work around that if we want to keep that version
> > working, or we could decide that it's time to officially stop supporting
> > that version, but we should probably decide on one or the other.
> >
>
> Good point.
> What is the minimum requirement of GCC version currently?
Good question ;-) (I recently had the impression that
Documentation/process/changes.rst was making fun of me ;-)
> AFAICS x86/asm-goto support requires GCC >= 4.5?
>
> Just FYI...
> ...saw the last days in upstream commits that kbuild/kconfig for
> 4.18-rc1 offers possibilities to check for cc-version dependencies.
Good to know! Mind retrieving/sharing the commit id(s)
or links to the corresponding discussion on LKML?
Thanks,
Andrea
>
> - sed@ -
next prev parent reply other threads:[~2018-06-08 11:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 20:49 [PATCH v4 0/3] extern inline native_save_fl for paravirt Nick Desaulniers
2018-06-07 20:49 ` [PATCH v4 1/3] compiler-gcc.h: add gnu_inline to all inline declarations Nick Desaulniers
2018-06-08 7:59 ` Arnd Bergmann
2018-06-08 10:04 ` Sedat Dilek
2018-06-08 11:28 ` Andrea Parri [this message]
2018-06-08 12:29 ` Sedat Dilek
2018-06-12 18:33 ` Nick Desaulniers
2018-06-12 18:51 ` H. Peter Anvin
2018-06-12 20:19 ` Nick Desaulniers
2018-06-12 21:31 ` H. Peter Anvin
2018-06-12 21:36 ` Nick Desaulniers
2018-06-07 20:49 ` [PATCH v4 2/3] x86/asm: add _ASM_ARG* constants for argument registers to <asm/asm.h> Nick Desaulniers
2018-06-07 20:49 ` [PATCH v4 3/3] x86: paravirt: make native_save_fl extern inline Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180608112826.GA7484@andrea \
--to=andrea.parri@amarulasolutions.com \
--cc=acme@redhat.com \
--cc=akataria@vmware.com \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=aryabinin@virtuozzo.com \
--cc=astrachan@google.com \
--cc=boris.ostrovsky@oracle.com \
--cc=brijesh.singh@amd.com \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=geert@linux-m68k.org \
--cc=ghackmann@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jan.kiszka@siemens.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgross@suse.com \
--cc=joe@perches.com \
--cc=jpoimboe@redhat.com \
--cc=keescook@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manojgupta@google.com \
--cc=mawilcox@microsoft.com \
--cc=michal.lkml@markovi.net \
--cc=mingo@redhat.com \
--cc=mjg59@google.com \
--cc=mka@chromium.org \
--cc=ndesaulniers@google.com \
--cc=pombredanne@nexb.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=sedat.dilek@gmail.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tstellar@redhat.com \
--cc=tweek@google.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).