From: Anton Vasilyev <vasilyev@ispras.ru>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Anton Vasilyev <vasilyev@ispras.ru>,
Johannes Thumshirn <jthumshirn@suse.de>,
Gaurav Pathak <gauravpathak129@gmail.com>,
Hannes Reinecke <hare@suse.de>, Sinan Kaya <okaya@codeaurora.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
ldv-project@linuxtesting.org
Subject: [PATCH] staging: rts5208: add check on NULL before dereference
Date: Sat, 9 Jun 2018 19:38:29 +0300 [thread overview]
Message-ID: <20180609163829.30619-1-vasilyev@ispras.ru> (raw)
If rtsx_probe fails to allocate dev->chip, then NULL pointer
dereference occurs at rtsx_release_resources().
Patch adds checks chip on NULL before its dereference at
rtsx_release_resources and passing with dereference inside
rtsx_release_chip.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>
---
drivers/staging/rts5208/rtsx.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
index 70e0b8623110..952dd0d580cf 100644
--- a/drivers/staging/rts5208/rtsx.c
+++ b/drivers/staging/rts5208/rtsx.c
@@ -623,12 +623,13 @@ static void rtsx_release_resources(struct rtsx_dev *dev)
if (dev->irq > 0)
free_irq(dev->irq, (void *)dev);
- if (dev->chip->msi_en)
+ if (dev->chip && dev->chip->msi_en)
pci_disable_msi(dev->pci);
if (dev->remap_addr)
iounmap(dev->remap_addr);
+ if (dev->chip)
+ rtsx_release_chip(dev->chip);
- rtsx_release_chip(dev->chip);
kfree(dev->chip);
}
--
2.17.1
next reply other threads:[~2018-06-09 16:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-09 16:38 Anton Vasilyev [this message]
2018-06-09 16:58 ` [PATCH] staging: rts5208: add check on NULL before dereference okaya
2018-06-09 19:34 ` Andy Shevchenko
2018-06-09 22:22 ` okaya
2018-06-12 13:06 ` Dan Carpenter
2018-06-13 16:55 ` [PATCH v2] " Anton Vasilyev
2018-06-13 17:00 ` Andy Shevchenko
2018-06-13 17:34 ` [PATCH v3] staging: rts5208: add error handling into rtsx_probe Anton Vasilyev
[not found] ` <20180613173128.32384-1-vasilyev@ispras.ru>
2018-06-19 7:42 ` your mail Dan Carpenter
2018-06-19 15:25 ` [PATCH v4] staging: rts5208: add error handling into rtsx_probe Anton Vasilyev
2018-06-19 17:13 ` Andy Shevchenko
2018-08-01 11:55 ` [PATCH v5] " Anton Vasilyev
2018-08-01 12:18 ` Andy Shevchenko
2018-08-01 14:08 ` Anton Vasilyev
2018-08-01 14:52 ` Dan Carpenter
2018-08-01 15:37 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180609163829.30619-1-vasilyev@ispras.ru \
--to=vasilyev@ispras.ru \
--cc=devel@driverdev.osuosl.org \
--cc=gauravpathak129@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=jthumshirn@suse.de \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=okaya@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).