linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Darren Hart <dvhart@infradead.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
	Linux-Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Hans de Goede <hdegoede@redhat.com>
Subject: Re: linux-next: build failure after merge of the drivers-x86 tree
Date: Mon, 11 Jun 2018 22:18:19 -0700	[thread overview]
Message-ID: <20180612051819.GB112645@localhost.localdomain> (raw)
In-Reply-To: <20180612112310.2d77e1c3@canb.auug.org.au>

On Tue, Jun 12, 2018 at 11:23:10AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the drivers-x86 tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/platform/x86/silead_dmi.c:84:21: error: variable 'chuwi_vi10_data' has initializer but incomplete type
>  static const struct ts_dmi_data chuwi_vi10_data = {
>                      ^~~~~~~~~~~
> drivers/platform/x86/silead_dmi.c:85:3: error: 'const struct ts_dmi_data' has no member named 'acpi_name'
>   .acpi_name      = "MSSL0002:00",
>    ^~~~~~~~~
> drivers/platform/x86/silead_dmi.c:85:20: warning: excess elements in struct initializer
>   .acpi_name      = "MSSL0002:00",
>                     ^~~~~~~~~~~~~
> drivers/platform/x86/silead_dmi.c:85:20: note: (near initialization for 'chuwi_vi10_data')
> drivers/platform/x86/silead_dmi.c:86:3: error: 'const struct ts_dmi_data' has no member named 'properties'
>   .properties     = chuwi_vi10_props,
>    ^~~~~~~~~~
> drivers/platform/x86/silead_dmi.c:86:20: warning: excess elements in struct initializer
>   .properties     = chuwi_vi10_props,
>                     ^~~~~~~~~~~~~~~~
> drivers/platform/x86/silead_dmi.c:86:20: note: (near initialization for 'chuwi_vi10_data')
> drivers/platform/x86/silead_dmi.c:84:33: error: storage size of 'chuwi_vi10_data' isn't known
>  static const struct ts_dmi_data chuwi_vi10_data = {
>                                  ^~~~~~~~~~~~~~~
> 
> Caused by commit
> 
>   2da502a0aea7 ("platform/x86: silead_dmi: Add touchscreen info for the Chuwi Vi10 tablet")
> 
> I have reverted that commit for today.  More care please.

Thank you Stephen. We caught this earlier, but failed to remove it from for-next
while repairing the series. Our apologies. I have removed this series back to
the known good patch in for-next:

26ed9d1 platform/x86: silead_dmi: Add entry for Chuwi Hi8 tablet touchscreen

Andy has this reworked already and is working on completing
testing before pushing the update to for-next.

-- 
Darren Hart
VMware Open Source Technology Center

  parent reply	other threads:[~2018-06-12  5:18 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-12  1:23 linux-next: build failure after merge of the drivers-x86 tree Stephen Rothwell
2018-06-12  3:28 ` dvhart
2018-06-12  5:18 ` Darren Hart [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-08-20  5:00 Stephen Rothwell
2021-08-20  7:31 ` M D
2021-08-20 10:11   ` Hans de Goede
2021-07-28 16:48 Mark Brown
2021-07-28 17:01 ` Andy Shevchenko
2021-07-28 17:27   ` Kammela, Gayatri
2021-07-28 17:55     ` Hans de Goede
2021-07-28 17:59       ` Kammela, Gayatri
2019-10-15  2:00 Stephen Rothwell
2019-10-15  8:04 ` Andy Shevchenko
2019-10-15 11:42   ` Stephen Rothwell
2015-06-05 10:13 Michael Ellerman
2015-06-08  4:52 ` Darren Hart
2015-06-04  8:13 Stephen Rothwell
2015-06-04 17:51 ` Radim Krčmář
2015-06-08  4:27   ` Darren Hart
2012-08-20  6:11 Stephen Rothwell
2012-08-20  6:44 ` AceLan Kao
2012-03-22  4:33 Stephen Rothwell
2012-03-21  5:52 Stephen Rothwell
2012-03-21 11:19 ` Matthew Garrett
2011-02-22  5:22 Stephen Rothwell
2011-02-22  6:26 ` Mattia Dongili
2011-02-22 11:46   ` Mattia Dongili
2011-02-22 14:34     ` Matthew Garrett
2011-02-22 22:22       ` Stephen Rothwell
2011-02-14  5:39 Stephen Rothwell
2011-02-14 22:42 ` Rafael J. Wysocki
2011-03-25  4:44 ` Stephen Rothwell
2011-02-08  3:45 Stephen Rothwell
2011-02-08  3:50 ` Matthew Garrett
2010-12-07  2:24 Stephen Rothwell
2010-10-05  4:11 Stephen Rothwell
2010-10-05 10:36 ` Ike Panhc
2010-10-06 10:45 ` Ike Panhc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180612051819.GB112645@localhost.localdomain \
    --to=dvhart@infradead.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).