From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by aws-us-west-2-korg-lkml-1.web.codeaurora.org (Postfix) with ESMTP id E7351C5CFF1 for ; Tue, 12 Jun 2018 21:42:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9899F2086D for ; Tue, 12 Jun 2018 21:42:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=tobin.cc header.i=@tobin.cc header.b="G45fNZ3X"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="e63O3zcO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9899F2086D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=tobin.cc Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934678AbeFLVmr (ORCPT ); Tue, 12 Jun 2018 17:42:47 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:42751 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932869AbeFLVmp (ORCPT ); Tue, 12 Jun 2018 17:42:45 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 45D4A21AD4; Tue, 12 Jun 2018 17:42:45 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 12 Jun 2018 17:42:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tobin.cc; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=U/dg3P8dIrtKH/lnsUlnTxSFe7c4SeYHbs6cYB/rlAE=; b=G45fNZ3X WKyk+36wXf0UA7wYbSBVWvsEb0x2NBoZ9QEsc4OOcz8hDE+EICzeSFheNpEHJ1vV w9dWBvbSGRBdsJIPLBgCzo8A67HtY13SrNnmXynwb2kC1rDXNhfEmZd4iFS4MvMw Rdw/qfF27amX+F10Xz3YWsJIwlfa4FesaUf7fnCF98dG7r2QMUFn9MxR4fohx3dg OqSerhZFRuB5r4neS/ND+gMbjYwI0Xjys3IApOq5jmr27LAH8J9yzfKpoWn1yH// zgykXmrD4ypiG/Y+nkdBZEM25ncGrOBDtrM5pkI3/L49rgSS8Nn6DuiiCJr1/6+U rg2+8cloN4Gk7Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=U/dg3P8dIrtKH/lnsUlnTxSFe7c4S eYHbs6cYB/rlAE=; b=e63O3zcONbZ38y2qrmcPjbORBZk50w/S5NvI2xyG4+ENu caz+XXaB6PYUmao314lvna3HGQN/YnFvTlo/OFGrcOadrNxAAaG8NI56gQn+JTPm /2VS6QVJxemTFabDxTqfG0U54kBBc4eBB3peB+N/n3x2JjZBH3H+xDoi1/asEb40 +EvzpRkBaNpmp47j1UAiRueV9Cr/3mvarj0bERh4Xotv8gaOeUH96zvJRnEYLPhz /LE+RHy9NdEeCMzA/gEIzhOr7+tioSQ/BQNuKbVzT2y4PTeCEUerMXTmpK4iasxy vUBWxZO7sUEHo0Dmns9Dq5/6vgZbTyIgeBBqGsURA== X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from localhost (ppp118-211-220-95.bras1.syd2.internode.on.net [118.211.220.95]) by mail.messagingengine.com (Postfix) with ESMTPA id 79C67E47A0; Tue, 12 Jun 2018 17:42:44 -0400 (EDT) Date: Wed, 13 Jun 2018 07:42:42 +1000 From: "Tobin C. Harding" To: Andy Shevchenko Cc: Theodore Ts'o , Linus Torvalds , Randy Dunlap , Steven Rostedt , Kees Cook , Anna-Maria Gleixner , Andrew Morton , Greg Kroah-Hartman , Arnd Bergmann , Linux Kernel Mailing List Subject: Re: [PATCH v7 2/4] random: Return nbytes filled from hw RNG Message-ID: <20180612214242.GB4528@eros> References: <1528763954-27731-1-git-send-email-me@tobin.cc> <1528763954-27731-3-git-send-email-me@tobin.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailer: Mutt 1.5.24 (2015-08-30) User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 12, 2018 at 11:39:56AM +0300, Andy Shevchenko wrote:. > On Tue, Jun 12, 2018 at 3:39 AM, Tobin C. Harding wrote: > > Currently the function get_random_bytes_arch() has return value 'void'. > > If the hw RNG fails we currently fall back to using get_random_bytes(). > > This defeats the purpose of requesting random material from the hw RNG > > in the first place. > > > - int chunk = min(nbytes, (int)sizeof(unsigned long)); > > + int chunk = min_t(int, left, (int)sizeof(unsigned long)); > > Isn't this (int) implied when you use min_t(int, ...) ? thanks Andy, will spin another version. Tobin