From: Bjorn Helgaas <helgaas@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-pci@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
shawn.lin@rock-chips.com
Subject: Re: [GIT PULL] PCI changes for v4.18, part 2
Date: Tue, 12 Jun 2018 18:09:50 -0500 [thread overview]
Message-ID: <20180612230950.GB96078@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <CA+55aFyo-NmP_zkyjnMXxJEq-93ha4akLDpF8biiFQ-hhWnZmg@mail.gmail.com>
On Tue, Jun 12, 2018 at 03:08:53PM -0700, Linus Torvalds wrote:
> On Tue, Jun 12, 2018 at 2:08 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
> >
> > - squash AER directory into drivers/pci/pcie/aer.c (Bjorn Helgaas)
>
> Could we please see *reasons* for this series of commits?
>
> Those commit messages have trivial "what", but no explanations "why".
The reason for this was to consolidate the AER-related code in one
file instead of several little ones:
$ wc -l drivers/pci/pcie/aer/*
141 drivers/pci/pcie/aer/aerdrv_acpi.c
371 drivers/pci/pcie/aer/aerdrv.c
496 drivers/pci/pcie/aer/aerdrv_core.c
260 drivers/pci/pcie/aer/aerdrv_errprint.c
95 drivers/pci/pcie/aer/aerdrv.h
550 drivers/pci/pcie/aer/aer_inject.c
117 drivers/pci/pcie/aer/ecrc.c
29 drivers/pci/pcie/aer/Kconfig
19 drivers/pci/pcie/aer/Kconfig.debug
13 drivers/pci/pcie/aer/Makefile
The original separation made logical sense but ended up being a hassle
in practice because following a thread of execution is always being
interrupted by having to find something in a different file.
Bjorn
prev parent reply other threads:[~2018-06-12 23:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 21:08 [GIT PULL] PCI changes for v4.18, part 2 Bjorn Helgaas
2018-06-12 22:08 ` Linus Torvalds
2018-06-12 22:27 ` Bjorn Helgaas
2018-06-12 22:48 ` Linus Torvalds
2018-06-12 23:09 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180612230950.GB96078@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=shawn.lin@rock-chips.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).