From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, T_DKIMWL_WL_HIGH,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by aws-us-west-2-korg-lkml-1.web.codeaurora.org (Postfix) with ESMTP id D3CD0C004E4 for ; Wed, 13 Jun 2018 11:49:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 85D67208B5 for ; Wed, 13 Jun 2018 11:49:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="WaAAkpZT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85D67208B5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935443AbeFMLtl (ORCPT ); Wed, 13 Jun 2018 07:49:41 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:56530 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935106AbeFMLtk (ORCPT ); Wed, 13 Jun 2018 07:49:40 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w5DBnCd7058731; Wed, 13 Jun 2018 11:49:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2017-10-26; bh=zhHlqNWtUi46rbrVgt4GyRwR5hiM3GeF92aEgyvjVgM=; b=WaAAkpZTaAw0CKUQEHUiMsZdpCJS18phn9F+aM/GsoD5fn5vmBkMi7XPg+yCFtmXGZyg SNDRE5JknXGff0uWYWREvtsHIRTJIpTndcOxRVe3uq3mB4qhb1NlvOFGEtR/kH2q4Po5 laUpDzF9ezIZ3ElFQX4r5r6uWM9xZ0bW2dXY6H1bYWpsKZvGcs2u6r2g9/MA8CLWgsct gSalLdB+rZ7u5Ly4Wo/nLHzcNkaSXdCV4R68Xhke8d5wKq2EdoSbnipOoWAnVVX+4arp QEWBgiU1G4HN9TKat3SQOuLymB8CqSBVo7MEU/4gX7OF5yzxlFRr2b145McU+h8WHKrq 2Q== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp2120.oracle.com with ESMTP id 2jk0xrgbg6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Jun 2018 11:49:12 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w5DBnB7Z014566 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Jun 2018 11:49:11 GMT Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w5DBn97U010565; Wed, 13 Jun 2018 11:49:09 GMT Received: from ca-dmjordan1.us.oracle.com (/10.211.9.48) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 13 Jun 2018 04:49:08 -0700 Date: Wed, 13 Jun 2018 04:49:09 -0700 From: Daniel Jordan To: "Huang, Ying" Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Kirill A. Shutemov" , Andrea Arcangeli , Michal Hocko , Johannes Weiner , Shaohua Li , Hugh Dickins , Minchan Kim , Rik van Riel , Dave Hansen , Naoya Horiguchi , Zi Yan Subject: Re: [PATCH -mm -V3 03/21] mm, THP, swap: Support PMD swap mapping in swap_duplicate() Message-ID: <20180613114909.alyfvvc5z2g2fbf7@ca-dmjordan1.us.oracle.com> References: <20180523082625.6897-1-ying.huang@intel.com> <20180523082625.6897-4-ying.huang@intel.com> <20180611204231.ojhlyrbmda6pouxb@ca-dmjordan1.us.oracle.com> <87o9ggpzlk.fsf@yhuang-dev.intel.com> <20180612214402.cpjmcyjkkwtkgjyu@ca-dmjordan1.us.oracle.com> <87vaano4rl.fsf@yhuang-dev.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87vaano4rl.fsf@yhuang-dev.intel.com> User-Agent: NeoMutt/20180323-268-5a959c X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8922 signatures=668702 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1805220000 definitions=main-1806130132 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 13, 2018 at 09:26:54AM +0800, Huang, Ying wrote: > Daniel Jordan writes: > > > On Tue, Jun 12, 2018 at 09:23:19AM +0800, Huang, Ying wrote: > >> Daniel Jordan writes: > >> >> +#else > >> >> +static inline int __swap_duplicate_cluster(swp_entry_t *entry, > >> > > >> > This doesn't need inline. > >> > >> Why not? This is just a one line stub. > > > > Forgot to respond to this. The compiler will likely choose to optimize out > > calls to an empty function like this. Checking, this is indeed what it does in > > this case on my machine, with or without inline. > > Yes. I believe a decent compiler will inline the function in any way. > And it does no harm to keep "inline" too, Yes? Right, it does no harm, it's just a matter of style.