From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Richard Weinberger <richard@nod.at>
Cc: Quentin Schulz <quentin.schulz@bootlin.com>,
marek.vasut@gmail.com, dedekind1@gmail.com,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
thomas.petazzoni@bootlin.com, computersforpeace@gmail.com,
dwmw2@infradead.org
Subject: Re: [PATCH 2/2] ubi: introduce ubi.nocheck parameter to skip CRC check when attaching ubi vol
Date: Thu, 14 Jun 2018 10:04:36 +0200 [thread overview]
Message-ID: <20180614100436.40741c67@bbrezillon> (raw)
In-Reply-To: <1588647.N1yrutfcI7@blindfold>
On Thu, 14 Jun 2018 09:29:42 +0200
Richard Weinberger <richard@nod.at> wrote:
> Quentin,
>
> Am Montag, 11. Juni 2018, 12:20:37 CEST schrieb Quentin Schulz:
> > If we go for a per-image flag, adding nocheck to the ioctl makes sense,
> > otherwise we have to find a way to select only one or more volumes for
> > which the nocheck flag should be set. That being said, I'm not sure a
> > per-image flag is the way we want to go.
> >
> > What are your thoughts on this?
>
> I like that approach a lot more, please send a patch. :-)
I don't think the approach you're talking about has been mentioned by
Quentin in this email :-). To clarify the discussion, we're talking
about adding a new flag to VTBL entries telling whether the CRC should
be skipped or not.
> Having a volume flag will reduce complexity a lot.
That's my opinion as well.
next prev parent reply other threads:[~2018-06-14 8:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 8:52 [PATCH 1/2] ubi: move constants for ubi vol parsing from kernel param to ubi.h Quentin Schulz
2018-04-20 8:52 ` [PATCH 2/2] ubi: introduce ubi.nocheck parameter to skip CRC check when attaching ubi vol Quentin Schulz
2018-04-20 9:37 ` Richard Weinberger
2018-04-20 9:50 ` Quentin Schulz
2018-06-11 10:20 ` Quentin Schulz
2018-06-14 7:29 ` Richard Weinberger
2018-06-14 8:04 ` Boris Brezillon [this message]
2018-06-14 8:07 ` Richard Weinberger
2018-04-20 17:19 ` Boris Brezillon
2018-04-23 9:40 ` Quentin Schulz
2018-04-23 12:08 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180614100436.40741c67@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=quentin.schulz@bootlin.com \
--cc=richard@nod.at \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).