From: Borislav Petkov <bp@alien8.de>
To: Johan Hovold <johan@kernel.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH 2/2] EDAC: i7core: fix memleaks and use-after-free on probe and remove
Date: Mon, 18 Jun 2018 13:32:06 +0200 [thread overview]
Message-ID: <20180618113205.GA24921@zn.tnic> (raw)
In-Reply-To: <20180612124335.6420-2-johan@kernel.org>
On Tue, Jun 12, 2018 at 02:43:35PM +0200, Johan Hovold wrote:
> Make sure to free and deregister the addrmatch and chancounts devices
> allocated during probe in all error paths. Also fix use-after-free in a
> probe error path and in the remove success path where the devices were
> being put before before deregistration.
>
> Fixes: 356f0a30860d ("i7core_edac: change the mem allocation scheme to make Documentation/kobject.txt happy")
> Cc: stable <stable@vger.kernel.org> # 3.6
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
> drivers/edac/i7core_edac.c | 22 +++++++++++++++-------
> 1 file changed, 15 insertions(+), 7 deletions(-)
Both applied, thanks.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
prev parent reply other threads:[~2018-06-18 11:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 12:43 [PATCH 1/2] EDAC: fix memleak in module init error path Johan Hovold
2018-06-12 12:43 ` [PATCH 2/2] EDAC: i7core: fix memleaks and use-after-free on probe and remove Johan Hovold
2018-06-18 11:32 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180618113205.GA24921@zn.tnic \
--to=bp@alien8.de \
--cc=johan@kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).