From: kbuild test robot <lkp@intel.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: kbuild-all@01.org, Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Joshua Thompson <funaho@jurai.org>,
Mathieu Malaterre <malat@debian.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Greg Ungerer <gerg@linux-m68k.org>,
linux-m68k@lists.linux-m68k.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, y2038@lists.linaro.org,
Meelis Roos <mroos@linux.ee>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 2/3] m68k: mac: use time64_t in RTC handling
Date: Tue, 19 Jun 2018 00:55:50 +0800 [thread overview]
Message-ID: <201806190005.ceeCMSOH%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180618140518.2920804-2-arnd@arndb.de>
[-- Attachment #1: Type: text/plain, Size: 2508 bytes --]
Hi Arnd,
I love your patch! Yet something to improve:
[auto build test ERROR on powerpc/next]
[also build test ERROR on v4.18-rc1 next-20180618]
[cannot apply to m68k/for-next]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Arnd-Bergmann/powerpc-mac-fix-rtc-read-functions/20180618-222412
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: m68k-multi_defconfig (attached as .config)
compiler: m68k-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=m68k
All errors (new ones prefixed by >>):
arch/m68k/mac/misc.c: In function 'cuda_read_time':
>> arch/m68k/mac/misc.c:48:36: error: expected expression before '|' token
time = (u32)((req.reply[3] << 24( | (req.reply[4] << 16) |
^
>> arch/m68k/mac/misc.c:48:32: error: called object is not a function or function pointer
time = (u32)((req.reply[3] << 24( | (req.reply[4] << 16) |
^~
>> arch/m68k/mac/misc.c:49:43: error: expected ')' before ';' token
(req.reply[5] << 8) | req.reply[6]);
^
arch/m68k/mac/misc.c:55:1: error: expected ')' before '}' token
}
^
>> arch/m68k/mac/misc.c:55:1: error: expected ';' before '}' token
arch/m68k/mac/misc.c:55:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
vim +48 arch/m68k/mac/misc.c
36
37 #ifdef CONFIG_ADB_CUDA
38 static time64_t cuda_read_time(void)
39 {
40 struct adb_request req;
41 time64_t time;
42
43 if (cuda_request(&req, NULL, 2, CUDA_PACKET, CUDA_GET_TIME) < 0)
44 return 0;
45 while (!req.complete)
46 cuda_poll();
47
> 48 time = (u32)((req.reply[3] << 24( | (req.reply[4] << 16) |
> 49 (req.reply[5] << 8) | req.reply[6]);
50
51 /* it's either after year 2040, or the RTC has gone backwards */
52 WARN_ON(time < RTC_OFFSET);
53
54 return time - RTC_OFFSET;
> 55 }
56
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 13188 bytes --]
next prev parent reply other threads:[~2018-06-18 16:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 14:05 [PATCH 1/3] powerpc: mac: fix rtc read functions Arnd Bergmann
2018-06-18 14:05 ` [PATCH 2/3] m68k: mac: use time64_t in RTC handling Arnd Bergmann
2018-06-18 16:55 ` kbuild test robot [this message]
2018-06-18 14:05 ` [PATCH 3/3] m68k: remove unused set_clock_mmss() helpers Arnd Bergmann
2018-06-19 13:07 ` Greg Ungerer
2018-06-18 19:10 ` [PATCH 1/3] powerpc: mac: fix rtc read functions Mathieu Malaterre
2018-06-18 20:04 ` Andreas Schwab
2018-06-19 5:47 ` Mathieu Malaterre
2018-06-19 10:18 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201806190005.ceeCMSOH%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=funaho@jurai.org \
--cc=geert@linux-m68k.org \
--cc=gerg@linux-m68k.org \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=malat@debian.org \
--cc=mpe@ellerman.id.au \
--cc=mroos@linux.ee \
--cc=paulus@samba.org \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).