From: Viresh Kumar <viresh.kumar@linaro.org>
To: Taniya Das <tdas@codeaurora.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Stephen Boyd <sboyd@kernel.org>,
robh@kernel.org, Rajendra Nayak <rnayak@codeaurora.org>,
devicetree@vger.kernel.org, skannan@codeaurora.org
Subject: Re: [PATCH 2/2] cpufreq: qcom-fw: Add support for QCOM cpufreq FW driver
Date: Tue, 19 Jun 2018 16:04:01 +0530 [thread overview]
Message-ID: <20180619103401.s3grdcm2hq6kx2pm@vireshk-i7> (raw)
In-Reply-To: <82d0646e-8dd7-43ba-6b5d-b772e57e865d@codeaurora.org>
On 19-06-18, 15:55, Taniya Das wrote:
> Yes, Viresh, earlier code was updating the table frequency as I was marking
> the table frequency INVALID.
> if (core_count != c->max_cores)
> c->table[i].frequency = CPUFREQ_ENTRY_INVALID;
>
> And thus I had to update the table frequency.
>
> But now I have used the cur_freq instead and the table frequency is not
> touched.
> if (core_count != c->max_cores)
> cur_freq = CPUFREQ_ENTRY_INVALID;
Unless I am reading your versions incorrectly, they behave differently.
Until V2, if core_count wasn't equal to max_cores then the frequency was getting
marked as INVALID straight away in the table itself. Now if the next freq is
also same then you abort and overwrite the previous one as valid, but otherwise
it remains INVALID for ever. And this last thing doesn't happen anymore.
So if in your table there are few frequency entries which aren't repeating, but
the core_count != max_cores for some of them, they remain valid in the newer
versions.
--
viresh
next prev parent reply other threads:[~2018-06-19 10:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-04 10:46 [PATCH v3 0/2] cpufreq: qcom-fw: Add support for QCOM cpufreq FW driver Taniya Das
2018-06-04 10:46 ` [PATCH 1/2] dt-bindings: cpufreq: Introduce QCOM CPUFREQ FW bindings Taniya Das
2018-06-04 10:55 ` Sudeep Holla
2018-06-07 7:20 ` Taniya Das
2018-06-07 12:57 ` Sudeep Holla
2018-06-06 4:42 ` Viresh Kumar
2018-06-04 10:46 ` [PATCH 2/2] cpufreq: qcom-fw: Add support for QCOM cpufreq FW driver Taniya Das
2018-06-06 6:01 ` Viresh Kumar
2018-06-07 7:18 ` Taniya Das
2018-06-19 8:54 ` Viresh Kumar
2018-06-19 10:25 ` Taniya Das
2018-06-19 10:34 ` Viresh Kumar [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-05-17 11:00 [v1 0/2] " Taniya Das
2018-05-17 11:00 ` [PATCH 2/2] cpufreq: qcom-fw: " Taniya Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180619103401.s3grdcm2hq6kx2pm@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rnayak@codeaurora.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=skannan@codeaurora.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).