From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EF19C433EF for ; Tue, 19 Jun 2018 14:29:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 047652083D for ; Tue, 19 Jun 2018 14:29:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 047652083D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gondor.apana.org.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757273AbeFSO3M (ORCPT ); Tue, 19 Jun 2018 10:29:12 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:34854 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757224AbeFSO3L (ORCPT ); Tue, 19 Jun 2018 10:29:11 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1fVHcv-0005nG-OZ; Tue, 19 Jun 2018 22:28:57 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1fVHcr-0007E7-U1; Tue, 19 Jun 2018 22:28:53 +0800 Date: Tue, 19 Jun 2018 22:28:53 +0800 From: Herbert Xu To: Vinod Koul Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Matt Mackall , Arnd Bergmann , Greg Kroah-Hartman , linux-arm-msm@vger.kernel.org, Vinod Koul Subject: Re: [PATCH 3/3] hwrng: msm - Add support for prng v2 Message-ID: <20180619142853.wgi5easw4zv6ttrb@gondor.apana.org.au> References: <20180618141259.23141-1-vkoul@kernel.org> <20180618141259.23141-4-vkoul@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180618141259.23141-4-vkoul@kernel.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 18, 2018 at 07:42:59PM +0530, Vinod Koul wrote: > Qcom 8996 and later chips support prng v2 where we need to only > implement .read callback for hwrng. > > Add a new table for v2 which supports this and get version required for > driver data. > > Signed-off-by: Vinod Koul Is this really a pseudo-RNG? If so it needs to be moved over to the algif_rng interface. hwrng is for true hardware RNGs only, because it may be directly fed into /dev/random. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt