From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EF35C43141 for ; Wed, 20 Jun 2018 16:42:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4181E20874 for ; Wed, 20 Jun 2018 16:42:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4181E20874 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932686AbeFTQmr (ORCPT ); Wed, 20 Jun 2018 12:42:47 -0400 Received: from mga07.intel.com ([134.134.136.100]:56744 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932494AbeFTQmp (ORCPT ); Wed, 20 Jun 2018 12:42:45 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jun 2018 09:42:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,248,1526367600"; d="scan'208";a="50538160" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga007.jf.intel.com with SMTP; 20 Jun 2018 09:42:41 -0700 Received: by stinkbox (sSMTP sendmail emulation); Wed, 20 Jun 2018 19:42:40 +0300 From: Ville Syrjala To: linux-bluetooth@vger.kernel.org Cc: Dmitry Torokhov , Greg Kroah-Hartman , Marcel Holtmann , Kay Sievers , =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= , systemd-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= Subject: [PATCH v2] hid2hci: Fix udev rules for linux-4.14+ Date: Wed, 20 Jun 2018 19:42:40 +0300 Message-Id: <20180620164240.6535-1-ville.syrjala@linux.intel.com> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20180507130638.3516-1-ville.syrjala@linux.intel.com> References: <20180507130638.3516-1-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ville Syrjälä Since commit 1455cf8dbfd0 ("driver core: emit uevents when device is bound to a driver") the kernel started emitting "bind" and "unbind" uevents which confuse the hid2hci udev rules. The symptoms on an affected machine (Dell E5400 in my case) include bluetooth devices not appearing and udev hogging the cpu as it's busy processing a constant stream of these "bind"+"unbind" uevents. Change the udev rules not do anything except for "add" and "change" events. This seems to cure my machine at least. v2: Don't mess up "change" (Zbyszek) Fix up the commit message a bit Cc: Dmitry Torokhov Cc: Greg Kroah-Hartman Cc: Marcel Holtmann Cc: Kay Sievers Cc: Zbigniew Jędrzejewski-Szmek Cc: systemd-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org Cc: linux-bluetooth@vger.kernel.org Signed-off-by: Ville Syrjälä --- tools/hid2hci.rules | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/hid2hci.rules b/tools/hid2hci.rules index db6bb03d2ef3..5c7208af7a02 100644 --- a/tools/hid2hci.rules +++ b/tools/hid2hci.rules @@ -1,6 +1,6 @@ # do not edit this file, it will be overwritten on update -ACTION=="remove", GOTO="hid2hci_end" +ACTION!="add|change", GOTO="hid2hci_end" SUBSYSTEM!="usb*", GOTO="hid2hci_end" # Variety of Dell Bluetooth devices - match on a mouse device that is -- 2.16.4