linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mel Gorman <mgorman@techsingularity.net>
To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Rik van Riel <riel@surriel.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v2 19/19] sched/numa: Move task_placement closer to numa_migrate_preferred
Date: Thu, 21 Jun 2018 11:06:32 +0100	[thread overview]
Message-ID: <20180621100632.bz4tukh6voftq3bo@techsingularity.net> (raw)
In-Reply-To: <1529514181-9842-20-git-send-email-srikar@linux.vnet.ibm.com>

On Wed, Jun 20, 2018 at 10:33:00PM +0530, Srikar Dronamraju wrote:
> numa_migrate_preferred is called periodically or when task preferred
> node changes. Preferred node evaluations happen once per scan sequence.
> 
> If the scan completion happens just after the periodic numa migration,
> then we try to migrate to the preferred node and the preferred node might
> change, needing another node migration.
> 
> Avoid this by checking for scan sequence completion only when checking
> for periodic migration.
> 
> Running SPECjbb2005 on a 4 node machine and comparing bops/JVM
> JVMS  LAST_PATCH  WITH_PATCH  %CHANGE
> 16    25862.6     26158.1     1.14258
> 1     74357       72725       -2.19482
> 
> Running SPECjbb2005 on a 16 node machine and comparing bops/JVM
> JVMS  LAST_PATCH  WITH_PATCH  %CHANGE
> 8     117019      113992      -2.58
> 1     179095      174947      -2.31
> 
> (numbers from v1 based on v4.17-rc5)
> Testcase       Time:         Min         Max         Avg      StdDev
> numa01.sh      Real:      449.46      770.77      615.22      101.70
> numa01.sh       Sys:      132.72      208.17      170.46       24.96
> numa01.sh      User:    39185.26    60290.89    50066.76     6807.84
> numa02.sh      Real:       60.85       61.79       61.28        0.37
> numa02.sh       Sys:       15.34       24.71       21.08        3.61
> numa02.sh      User:     5204.41     5249.85     5231.21       17.60
> numa03.sh      Real:      785.50      916.97      840.77       44.98
> numa03.sh       Sys:      108.08      133.60      119.43        8.82
> numa03.sh      User:    61422.86    70919.75    64720.87     3310.61
> numa04.sh      Real:      429.57      587.37      480.80       57.40
> numa04.sh       Sys:      240.61      321.97      290.84       33.58
> numa04.sh      User:    34597.65    40498.99    37079.48     2060.72
> numa05.sh      Real:      392.09      431.25      414.65       13.82
> numa05.sh       Sys:      229.41      372.48      297.54       53.14
> numa05.sh      User:    33390.86    34697.49    34222.43      556.42
> 
> 
> Testcase       Time:         Min         Max         Avg      StdDev 	%Change
> numa01.sh      Real:      424.63      566.18      498.12       59.26 	 23.50%
> numa01.sh       Sys:      160.19      256.53      208.98       37.02 	 -18.4%
> numa01.sh      User:    37320.00    46225.58    42001.57     3482.45 	 19.20%
> numa02.sh      Real:       60.17       62.47       60.91        0.85 	 0.607%
> numa02.sh       Sys:       15.30       22.82       17.04        2.90 	 23.70%
> numa02.sh      User:     5202.13     5255.51     5219.08       20.14 	 0.232%
> numa03.sh      Real:      823.91      844.89      833.86        8.46 	 0.828%
> numa03.sh       Sys:      130.69      148.29      140.47        6.21 	 -14.9%
> numa03.sh      User:    62519.15    64262.20    63613.38      620.05 	 1.740%
> numa04.sh      Real:      515.30      603.74      548.56       30.93 	 -12.3%
> numa04.sh       Sys:      459.73      525.48      489.18       21.63 	 -40.5%
> numa04.sh      User:    40561.96    44919.18    42047.87     1526.85 	 -11.8%
> numa05.sh      Real:      396.58      454.37      421.13       19.71 	 -1.53%
> numa05.sh       Sys:      208.72      422.02      348.90       73.60 	 -14.7%
> numa05.sh      User:    33124.08    36109.35    34846.47     1089.74 	 -1.79%
> 
> Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>

Acked-by: Mel Gorman <mgorman@techsingularity.net>

-- 
Mel Gorman
SUSE Labs

  reply	other threads:[~2018-06-21 10:06 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-20 17:02 [PATCH v2 00/19] Fixes for sched/numa_balancing Srikar Dronamraju
2018-06-20 17:02 ` [PATCH v2 01/19] sched/numa: Remove redundant field Srikar Dronamraju
2018-07-25 14:23   ` [tip:sched/core] " tip-bot for Srikar Dronamraju
2018-06-20 17:02 ` [PATCH v2 02/19] sched/numa: Evaluate move once per node Srikar Dronamraju
2018-06-21  9:06   ` Mel Gorman
2018-07-25 14:24   ` [tip:sched/core] " tip-bot for Srikar Dronamraju
2018-06-20 17:02 ` [PATCH v2 03/19] sched/numa: Simplify load_too_imbalanced Srikar Dronamraju
2018-07-25 14:24   ` [tip:sched/core] sched/numa: Simplify load_too_imbalanced() tip-bot for Srikar Dronamraju
2018-06-20 17:02 ` [PATCH v2 04/19] sched/numa: Set preferred_node based on best_cpu Srikar Dronamraju
2018-06-21  9:17   ` Mel Gorman
2018-07-25 14:25   ` [tip:sched/core] " tip-bot for Srikar Dronamraju
2018-06-20 17:02 ` [PATCH v2 05/19] sched/numa: Use task faults only if numa_group is not yet setup Srikar Dronamraju
2018-06-21  9:38   ` Mel Gorman
2018-07-25 14:25   ` [tip:sched/core] sched/numa: Use task faults only if numa_group is not yet set up tip-bot for Srikar Dronamraju
2018-06-20 17:02 ` [PATCH v2 06/19] sched/debug: Reverse the order of printing faults Srikar Dronamraju
2018-07-25 14:26   ` [tip:sched/core] " tip-bot for Srikar Dronamraju
2018-06-20 17:02 ` [PATCH v2 07/19] sched/numa: Skip nodes that are at hoplimit Srikar Dronamraju
2018-07-25 14:27   ` [tip:sched/core] sched/numa: Skip nodes that are at 'hoplimit' tip-bot for Srikar Dronamraju
2018-06-20 17:02 ` [PATCH v2 08/19] sched/numa: Remove unused task_capacity from numa_stats Srikar Dronamraju
2018-07-25 14:27   ` [tip:sched/core] sched/numa: Remove unused task_capacity from 'struct numa_stats' tip-bot for Srikar Dronamraju
2018-06-20 17:02 ` [PATCH v2 09/19] sched/numa: Modify migrate_swap to accept additional params Srikar Dronamraju
2018-07-25 14:28   ` [tip:sched/core] sched/numa: Modify migrate_swap() to accept additional parameters tip-bot for Srikar Dronamraju
2018-06-20 17:02 ` [PATCH v2 10/19] sched/numa: Stop multiple tasks from moving to the cpu at the same time Srikar Dronamraju
2018-06-20 17:02 ` [PATCH v2 11/19] sched/numa: Restrict migrating in parallel to the same node Srikar Dronamraju
2018-07-23 10:38   ` Peter Zijlstra
2018-07-23 11:16     ` Srikar Dronamraju
2018-06-20 17:02 ` [PATCH v2 12/19] sched/numa: Remove numa_has_capacity Srikar Dronamraju
2018-07-25 14:28   ` [tip:sched/core] sched/numa: Remove numa_has_capacity() tip-bot for Srikar Dronamraju
2018-06-20 17:02 ` [PATCH v2 13/19] mm/migrate: Use xchg instead of spinlock Srikar Dronamraju
2018-06-21  9:51   ` Mel Gorman
2018-07-23 10:54   ` Peter Zijlstra
2018-07-23 11:20     ` Srikar Dronamraju
2018-07-23 14:04       ` Peter Zijlstra
2018-06-20 17:02 ` [PATCH v2 14/19] sched/numa: Updation of scan period need not be in lock Srikar Dronamraju
2018-06-21  9:51   ` Mel Gorman
2018-07-25 14:29   ` [tip:sched/core] sched/numa: Update the scan period without holding the numa_group lock tip-bot for Srikar Dronamraju
2018-06-20 17:02 ` [PATCH v2 15/19] sched/numa: Use group_weights to identify if migration degrades locality Srikar Dronamraju
2018-07-25 14:29   ` [tip:sched/core] " tip-bot for Srikar Dronamraju
2018-06-20 17:02 ` [PATCH v2 16/19] sched/numa: Detect if node actively handling migration Srikar Dronamraju
2018-06-20 17:02 ` [PATCH v2 17/19] sched/numa: Pass destination cpu as a parameter to migrate_task_rq Srikar Dronamraju
2018-06-20 17:02 ` [PATCH v2 18/19] sched/numa: Reset scan rate whenever task moves across nodes Srikar Dronamraju
2018-06-21 10:05   ` Mel Gorman
2018-07-04 11:19     ` Srikar Dronamraju
2018-06-20 17:03 ` [PATCH v2 19/19] sched/numa: Move task_placement closer to numa_migrate_preferred Srikar Dronamraju
2018-06-21 10:06   ` Mel Gorman [this message]
2018-07-25 14:30   ` [tip:sched/core] sched/numa: Move task_numa_placement() closer to numa_migrate_preferred() tip-bot for Srikar Dronamraju
2018-06-20 17:03 ` [PATCH v2 00/19] Fixes for sched/numa_balancing Srikar Dronamraju
2018-07-23 13:57 ` Peter Zijlstra
2018-07-23 15:09   ` Srikar Dronamraju
2018-07-23 15:21     ` Peter Zijlstra
2018-07-23 16:29       ` Srikar Dronamraju
2018-07-23 16:47         ` Peter Zijlstra
2018-07-23 15:33     ` Rik van Riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180621100632.bz4tukh6voftq3bo@techsingularity.net \
    --to=mgorman@techsingularity.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=riel@surriel.com \
    --cc=srikar@linux.vnet.ibm.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).