From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Matt Delco <delco@chromium.org>
Cc: AceLan Kao <acelan.kao@canonical.com>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
platform-driver-x86@vger.kernel.or, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: intel-vbtn: Ignore extraneous events from tablet mode
Date: Thu, 21 Jun 2018 13:37:45 -0700 [thread overview]
Message-ID: <20180621203745.GA50452@dtor-ws> (raw)
In-Reply-To: <20180621201207.178426-1-delco@chromium.org>
On Thu, Jun 21, 2018 at 01:12:07PM -0700, Matt Delco wrote:
> The Dell laptop I have has an ACPI that sends 0xCB and 0xCC on entering
> tablet mode. On exiting tablet mode it sends 0xCA and 0xCD. This
> change has the driver ignore 0xCA and 0xCB.
>
> Signed-off-by: Matt Delco <delco@chromium.org>
This looks good to me.
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> drivers/platform/x86/intel-vbtn.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c
> index c13780b8dabb..4c6f2bb1d1ac 100644
> --- a/drivers/platform/x86/intel-vbtn.c
> +++ b/drivers/platform/x86/intel-vbtn.c
> @@ -38,8 +38,10 @@ static const struct key_entry intel_vbtn_keymap[] = {
> { KE_IGNORE, 0xC7, { KEY_VOLUMEDOWN } }, /* volume-down key release */
> { KE_KEY, 0xC8, { KEY_ROTATE_LOCK_TOGGLE } }, /* rotate-lock key press */
> { KE_KEY, 0xC9, { KEY_ROTATE_LOCK_TOGGLE } }, /* rotate-lock key release */
> - { KE_SW, 0xCC, { .sw = { SW_TABLET_MODE, 1 } } }, /* Tablet */
> - { KE_SW, 0xCD, { .sw = { SW_TABLET_MODE, 0 } } }, /* Laptop */
> + { KE_IGNORE, 0xCA, { KEY_UNKNOWN } }, /* Laptop key press */
> + { KE_IGNORE, 0xCB, { KEY_UNKNOWN } }, /* Tablet key press */
> + { KE_SW, 0xCC, { .sw = { SW_TABLET_MODE, 1 } } }, /* Tablet key release */
> + { KE_SW, 0xCD, { .sw = { SW_TABLET_MODE, 0 } } }, /* Laptop key release */
> { KE_END },
> };
>
> --
> 2.18.0.rc2.346.g013aa6912e-goog
>
--
Dmitry
next prev parent reply other threads:[~2018-06-21 20:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 20:12 [PATCH] platform/x86: intel-vbtn: Ignore extraneous events from tablet mode Matt Delco
2018-06-21 20:37 ` Dmitry Torokhov [this message]
2018-06-25 6:14 ` AceLan Kao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180621203745.GA50452@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=acelan.kao@canonical.com \
--cc=andy@infradead.org \
--cc=delco@chromium.org \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.or \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).