From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBA99C43143 for ; Fri, 22 Jun 2018 05:09:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9CBA223D62 for ; Fri, 22 Jun 2018 05:09:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CBA223D62 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751398AbeFVFI7 (ORCPT ); Fri, 22 Jun 2018 01:08:59 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:44794 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750937AbeFVFI5 (ORCPT ); Fri, 22 Jun 2018 01:08:57 -0400 Received: from localhost (unknown [211.196.191.92]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id C26CF119C1EE5; Thu, 21 Jun 2018 22:08:52 -0700 (PDT) Date: Fri, 22 Jun 2018 14:08:50 +0900 (KST) Message-Id: <20180622.140850.2131338572840772705.davem@davemloft.net> To: kai.heng.feng@canonical.com Cc: ryankao@realtek.com, hayeswang@realtek.com, hau@realtek.com, hkallweit1@gmail.com, romieu@fr.zoreil.com, bhelgaas@google.com, acelan.kao@canonical.com, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v4 2/2] r8169: Reinstate ASPM Support From: David Miller In-Reply-To: <20180621083039.22545-2-kai.heng.feng@canonical.com> References: <20180621083039.22545-1-kai.heng.feng@canonical.com> <20180621083039.22545-2-kai.heng.feng@canonical.com> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 21 Jun 2018 22:08:57 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kai-Heng Feng Date: Thu, 21 Jun 2018 16:30:39 +0800 > On Intel platforms (Skylake and newer), ASPM support in r8169 is the > last missing puzzle to let CPU's Package C-State reaches PC8. Without > ASPM support, the CPU cannot reach beyond PC3. PC8 can save additional > ~3W in comparison with PC3 on a Coffee Lake platform, Dell G3 3779. > > This is based on the work from Chunhao Lin . > > Signed-off-by: Kai-Heng Feng Also applied. Thank you for being so persistent.