From: Ingo Molnar <mingo@kernel.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: mingo@redhat.com, tglx@linutronix.de, akpm@linux-foundation.org,
hpa@zytor.com, linux-efi@vger.kernel.org,
linux-kernel@vger.kernel.org, x86@kernel.org,
virtualization@lists.linux-foundation.org, astrachan@google.com,
manojgupta@google.com, ghackmann@google.com,
sedat.dilek@gmail.com, tstellar@redhat.com, keescook@google.com,
yamada.masahiro@socionext.com, michal.lkml@markovi.net,
linux-kbuild@vger.kernel.org, geert@linux-m68k.org,
will.deacon@arm.com, mawilcox@microsoft.com, arnd@arndb.de,
rientjes@google.com, acme@redhat.com, pombredanne@nexb.com,
aryabinin@virtuozzo.com, kstewart@linuxfoundation.org,
boris.ostrovsky@oracle.com, jan.kiszka@siemens.com,
rostedt@goodmis.org, kirill.shutemov@linux.intel.com,
ard.biesheuvel@linaro.org, akataria@vmware.com,
brijesh.singh@amd.com, caoj.fnst@cn.fujitsu.com,
gregkh@linuxfoundation.org, jarkko.sakkinen@linux.intel.com,
jgross@suse.com, jpoimboe@redhat.com, mka@chromium.org,
thomas.lendacky@amd.com, tweek@google.com, mjg59@google.com,
joe@perches.com, andrea.parri@amarulasolutions.com
Subject: Re: [PATCH v6 3/3] x86: paravirt: make native_save_fl extern inline
Date: Fri, 22 Jun 2018 04:24:02 +0200 [thread overview]
Message-ID: <20180622022402.GA24194@gmail.com> (raw)
In-Reply-To: <20180621162324.36656-4-ndesaulniers@google.com>
* Nick Desaulniers <ndesaulniers@google.com> wrote:
> native_save_fl() is marked static inline, but by using it as
> a function pointer in arch/x86/kernel/paravirt.c, it MUST be outlined.
> --- a/arch/x86/include/asm/irqflags.h
> +++ b/arch/x86/include/asm/irqflags.h
> @@ -13,7 +13,7 @@
> * Interrupt control:
> */
>
> -static inline unsigned long native_save_fl(void)
> +extern inline unsigned long native_save_fl(void)
> {
> unsigned long flags;
>
What's the code generation effect of this on say a defconfig kernel vmlinux with
paravirt enabled?
Thanks,
Ingo
next prev parent reply other threads:[~2018-06-22 2:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 16:23 [PATCH v6 0/3] extern inline native_save_fl for paravirt Nick Desaulniers
2018-06-21 16:23 ` [PATCH v6 1/3] compiler-gcc.h: add gnu_inline to all inline declarations Nick Desaulniers
2018-07-03 15:59 ` [tip:x86/urgent] compiler-gcc.h: Add __attribute__((gnu_inline)) " tip-bot for Nick Desaulniers
2018-06-21 16:23 ` [PATCH v6 2/3] x86/asm: add _ASM_ARG* constants for argument registers to <asm/asm.h> Nick Desaulniers
2018-07-03 15:59 ` [tip:x86/urgent] x86/asm: Add " tip-bot for H. Peter Anvin
2018-06-21 16:23 ` [PATCH v6 3/3] x86: paravirt: make native_save_fl extern inline Nick Desaulniers
2018-06-22 2:24 ` Ingo Molnar [this message]
2018-06-22 17:10 ` Nick Desaulniers
2018-06-26 7:13 ` Ingo Molnar
2018-06-26 16:22 ` Nick Desaulniers
2018-07-03 7:21 ` Juergen Gross
2018-07-03 16:00 ` [tip:x86/urgent] x86/paravirt: Make native_save_fl() " tip-bot for Nick Desaulniers
[not found] ` <1e19dbef068b45a4a4e9eb4072e097be@AcuMS.aculab.com>
2018-07-16 17:27 ` [PATCH v6 3/3] x86: paravirt: make native_save_fl " Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180622022402.GA24194@gmail.com \
--to=mingo@kernel.org \
--cc=acme@redhat.com \
--cc=akataria@vmware.com \
--cc=akpm@linux-foundation.org \
--cc=andrea.parri@amarulasolutions.com \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=aryabinin@virtuozzo.com \
--cc=astrachan@google.com \
--cc=boris.ostrovsky@oracle.com \
--cc=brijesh.singh@amd.com \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=geert@linux-m68k.org \
--cc=ghackmann@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jan.kiszka@siemens.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgross@suse.com \
--cc=joe@perches.com \
--cc=jpoimboe@redhat.com \
--cc=keescook@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manojgupta@google.com \
--cc=mawilcox@microsoft.com \
--cc=michal.lkml@markovi.net \
--cc=mingo@redhat.com \
--cc=mjg59@google.com \
--cc=mka@chromium.org \
--cc=ndesaulniers@google.com \
--cc=pombredanne@nexb.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=sedat.dilek@gmail.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tstellar@redhat.com \
--cc=tweek@google.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).