From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Rob Herring <robh@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH] devres: Add devm_of_iomap()
Date: Fri, 22 Jun 2018 14:09:41 +0900 [thread overview]
Message-ID: <20180622050941.GA28638@kroah.com> (raw)
In-Reply-To: <5a28adfe74dcea35d704d98e54b2bbb72bcd6b8f.camel@kernel.crashing.org>
On Fri, Jun 22, 2018 at 02:13:15PM +1000, Benjamin Herrenschmidt wrote:
> On Thu, 2018-06-14 at 13:31 +1000, Benjamin Herrenschmidt wrote:
> > There are still quite a few cases where a device might want
> > to get to a different node of the device-tree, obtain the
> > resources and map them.
> >
> > This is generally open coded in drivers which is quite error prone
> >
> > We have of_iomap() and of_io_request_and_map() but they both
> > have shortcomings, such as not returning the size of the
> > resource found (which can be useful) and not being "managed".
> >
> > This adds a devm_of_iomap() that provides all of these and
> > should probably replace uses of the above in most drivers.
> >
> > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > ---
>
> Greg, which tree should this go through ? Rob, ack pls ? :-)
>
> I have dependencies on this coming up... I can put it in the FSI tree
> if you want, it will be part of my next pull request.
Usually new devres patches just go through whatever tree needs it, so no
objection from me for you to take these in your next pull request.
thanks,
greg k-h
prev parent reply other threads:[~2018-06-22 5:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 3:31 [PATCH] devres: Add devm_of_iomap() Benjamin Herrenschmidt
2018-06-22 4:13 ` Benjamin Herrenschmidt
2018-06-22 5:09 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180622050941.GA28638@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).