From: Jan Kara <jack@suse.cz>
To: Matthew Wilcox <willy@infradead.org>
Cc: Jia-Ju Bai <baijiaju1990@gmail.com>,
axboe@kernel.dk, akpm@linux-foundation.or, jack@suse.cz,
zhangweiping@didichuxing.com, sergey.senozhatsky@gmail.com,
andriy.shevchenko@linux.intel.com, christophe.jaillet@wanadoo.fr,
aryabinin@virtuozzo.com, linux-mm@kvack.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] mm: backing-dev: a possible sleep-in-atomic-context bug in cgwb_create()
Date: Fri, 22 Jun 2018 10:50:35 +0200 [thread overview]
Message-ID: <20180622085035.2zn2voqgqxcx55f3@quack2.suse.cz> (raw)
In-Reply-To: <20180621033515.GA12608@bombadil.infradead.org>
On Wed 20-06-18 20:35:15, Matthew Wilcox wrote:
> On Thu, Jun 21, 2018 at 11:02:58AM +0800, Jia-Ju Bai wrote:
> > The kernel may sleep with holding a spinlock.
> > The function call path (from bottom to top) in Linux-4.16.7 is:
> >
> > [FUNC] schedule
> > lib/percpu-refcount.c, 222:
> > schedule in __percpu_ref_switch_mode
> > lib/percpu-refcount.c, 339:
> > __percpu_ref_switch_mode in percpu_ref_kill_and_confirm
> > ./include/linux/percpu-refcount.h, 127:
> > percpu_ref_kill_and_confirm in percpu_ref_kill
> > mm/backing-dev.c, 545:
> > percpu_ref_kill in cgwb_kill
> > mm/backing-dev.c, 576:
> > cgwb_kill in cgwb_create
> > mm/backing-dev.c, 573:
> > _raw_spin_lock_irqsave in cgwb_create
> >
> > This bug is found by my static analysis tool (DSAC-2) and checked by my
> > code review.
>
> I disagree with your code review.
>
> * If the previous ATOMIC switching hasn't finished yet, wait for
> * its completion. If the caller ensures that ATOMIC switching
> * isn't in progress, this function can be called from any context.
>
> I believe cgwb_kill is always called under the spinlock, so we will never
> sleep because the percpu ref will never be switching to atomic mode.
You are right that the sleep under spinlock never happens. And the reason
is that percpu_ref_kill() never results in blocking - it does call
percpu_ref_kill_and_confirm() but the 'confirm' argument is NULL and thus
even percpu_ref_kill_and_confirm() never blocks.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2018-06-22 8:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 3:02 [BUG] mm: backing-dev: a possible sleep-in-atomic-context bug in cgwb_create() Jia-Ju Bai
2018-06-21 3:35 ` Matthew Wilcox
2018-06-22 8:50 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180622085035.2zn2voqgqxcx55f3@quack2.suse.cz \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.or \
--cc=andriy.shevchenko@linux.intel.com \
--cc=aryabinin@virtuozzo.com \
--cc=axboe@kernel.dk \
--cc=baijiaju1990@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=willy@infradead.org \
--cc=zhangweiping@didichuxing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).