From: Greg KH <greg@kroah.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
linux-kernel@vger.kernel.org,
Gwendal Grignou <gwendal@chromium.org>,
kernel@collabora.com, linux-rtc@vger.kernel.org,
Alessandro Zummo <a.zummo@towertech.it>
Subject: Re: [PATCH 5/9] rtc: cros-ec: Switch to SPDX identifier.
Date: Mon, 25 Jun 2018 09:58:32 +0800 [thread overview]
Message-ID: <20180625015832.GB30408@kroah.com> (raw)
In-Reply-To: <20180605185952.GG4637@piout.net>
On Tue, Jun 05, 2018 at 08:59:52PM +0200, Alexandre Belloni wrote:
> On 05/06/2018 20:51:06+0200, Enric Balletbo i Serra wrote:
> > Hi Alexandre,
> >
> > On 05/06/18 11:46, Alexandre Belloni wrote:
> > > On 05/06/2018 11:22:05+0200, Enric Balletbo i Serra wrote:
> > >> Adopt the SPDX license identifier headers to ease license compliance
> > >> management.
> > >>
> > >> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> > >> ---
> > >>
> > >> drivers/rtc/rtc-cros-ec.c | 21 +++++----------------
> > >> 1 file changed, 5 insertions(+), 16 deletions(-)
> > >>
> > > Applied, thanks.
> > >
> >
> > Looks like all the ChromeOS drivers should be licensed as GPL v2 only. There was
> > a mismatch between what the header says and the MODULE_LICENSE and I wrongly
> > assumed that the MODULE_LICENSE is the one I should follow. So could you not
> > apply this patch for now and I'll send another version with the correct license?
> >
>
> Hum, ok, this seemed to be the correct way to solve the mismatch to me.
No, the license text trumps the MODULE_LICENSE() string. Please revert
this, or fix it up to be correct.
thanks,
greg k-h
next prev parent reply other threads:[~2018-06-25 2:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 9:22 [PATCH 0/9] croc_ec: Switch to SPDX identifier Enric Balletbo i Serra
2018-06-05 9:22 ` [PATCH 1/9] platform/chrome: cros_ec: " Enric Balletbo i Serra
2018-06-05 11:57 ` Emilio Pozuelo Monfort
2018-06-05 9:22 ` [PATCH 2/9] platform/chrome: pstore: " Enric Balletbo i Serra
2018-06-05 9:22 ` [PATCH 3/9] mfd: cros_ec: Add or fix SPDX-License-Identifier in all files Enric Balletbo i Serra
2018-06-05 9:22 ` [PATCH 4/9] iio: cros_ec: Switch to SPDX identifier Enric Balletbo i Serra
2018-06-10 13:40 ` Jonathan Cameron
2018-06-05 9:22 ` [PATCH 5/9] rtc: cros-ec: " Enric Balletbo i Serra
2018-06-05 9:46 ` Alexandre Belloni
2018-06-05 18:51 ` Enric Balletbo i Serra
2018-06-05 18:59 ` Alexandre Belloni
2018-06-25 1:58 ` Greg KH [this message]
2018-06-25 7:34 ` Alexandre Belloni
2018-06-25 11:06 ` Greg KH
2018-06-05 9:22 ` [PATCH 6/9] Input: cros_ec_keyb - " Enric Balletbo i Serra
2018-06-05 16:37 ` Dmitry Torokhov
2018-06-05 9:22 ` [PATCH 7/9] pwm: cros-ec: " Enric Balletbo i Serra
2018-06-05 9:22 ` [PATCH 8/9] extcon: usbc-cros-ec: " Enric Balletbo i Serra
2018-06-05 9:30 ` Chanwoo Choi
2018-06-05 9:34 ` Enric Balletbo i Serra
2018-06-05 9:22 ` [PATCH 9/9] i2c: i2c-cros-ec-tunnel: " Enric Balletbo i Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180625015832.GB30408@kroah.com \
--to=greg@kroah.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=enric.balletbo@collabora.com \
--cc=gwendal@chromium.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).