From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
Borislav Petkov <bp@alien8.de>,
linux-crypto@vger.kernel.org, Mike Galbraith <efault@gmx.de>,
torvalds@linux-foundation.org, tglx@linutronix.de,
luto@kernel.org, peterz@infradead.org, brgerst@gmail.com,
hpa@zytor.com, linux-kernel@vger.kernel.org, dvlasenk@redhat.com,
h.peter.anvin@intel.com,
linux-tip-commits <linux-tip-commits@vger.kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] x86/crypto: Add missing RETs
Date: Mon, 25 Jun 2018 08:19:32 -0500 [thread overview]
Message-ID: <20180625131932.sge43esxdb5ejoxg@treble> (raw)
In-Reply-To: <20180625072438.GA19063@gmail.com>
On Mon, Jun 25, 2018 at 09:24:38AM +0200, Ingo Molnar wrote:
>
> * Alexey Dobriyan <adobriyan@gmail.com> wrote:
>
> > On Sun, Jun 24, 2018 at 09:11:05AM +0200, Ingo Molnar wrote:
> > > > Add explicit RETs to the tail calls of AEGIS and MORUS crypto algorithms
> > > > otherwise they run into INT3 padding due to
> > > >
> > > > 51bad67ffbce ("x86/asm: Pad assembly functions with INT3 instructions")
> > > >
> > > > leading to spurious debug exceptions.
> > > >
> > > > Mike Galbraith <efault@gmx.de> took care of all the remaining callsites.
> > >
> > > Note that 51bad67ffbce has been zapped because it caused too many problems like
> > > this, but the explicit RETs make sense nevertheless.
> >
> > So commit which found real bug(s) was zapped.
> >
> > OK
>
> No, what happened is that the commit was first moved into WIP.x86/debug showing
> its work-in-progress status, because it was incomplete and caused bugs:
>
> https://lore.kernel.org/lkml/20180518073644.GA8593@gmail.com/T/#u
>
> ... and finally, after weeks of inaction I zapped it because I didn't see progress
> and you didn't answer my question.
>
> If a fixed patch with updated tooling to detect these crashes before they occur on
> live systems is submitted we'll reconsider - it didn't get NAK-ed, it's just
> incomplete in the current form.
Hm, what happened to the objtool patch to detect these at build time?
Did it not work?
https://lore.kernel.org/lkml/20180517134934.eog2fgoby5azq5a7@treble
--
Josh
next prev parent reply other threads:[~2018-06-25 13:19 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-07 21:37 [PATCH] x86: pad assembly functions with INT3 Alexey Dobriyan
2018-05-07 21:41 ` hpa
2018-05-09 16:55 ` Alexey Dobriyan
2018-05-09 19:28 ` H. Peter Anvin
2018-05-10 16:39 ` David Laight
2018-05-11 18:53 ` H. Peter Anvin
2018-05-14 9:04 ` David Laight
2018-05-14 11:05 ` hpa
2018-05-15 6:54 ` Ingo Molnar
2018-05-15 6:59 ` hpa
2018-05-14 12:53 ` [tip:x86/pti] x86/asm: Pad assembly functions with INT3 instructions tip-bot for Alexey Dobriyan
2018-06-17 11:40 ` Mike Galbraith
2018-06-17 12:00 ` Borislav Petkov
2018-06-17 13:38 ` Mike Galbraith
2018-06-17 14:02 ` Mike Galbraith
2018-06-17 19:47 ` Borislav Petkov
2018-06-18 2:34 ` Mike Galbraith
2018-06-23 10:36 ` [PATCH] x86/crypto: Add missing RETs Borislav Petkov
2018-06-23 17:30 ` Ondrej Mosnáček
2018-06-24 7:11 ` Ingo Molnar
2018-06-24 7:12 ` Thomas Gleixner
2018-06-24 10:15 ` Borislav Petkov
2018-06-24 10:44 ` Alexey Dobriyan
2018-06-25 7:24 ` Ingo Molnar
2018-06-25 13:19 ` Josh Poimboeuf [this message]
2018-06-26 6:49 ` Ingo Molnar
2018-06-26 12:31 ` Josh Poimboeuf
2018-07-05 7:58 ` Ingo Molnar
2018-07-06 14:06 ` Josh Poimboeuf
2018-07-06 14:57 ` Ingo Molnar
2018-07-01 13:19 ` Herbert Xu
2018-07-01 15:24 ` Ondrej Mosnáček
2018-07-01 15:45 ` Herbert Xu
2018-06-19 11:27 ` [tip:x86/pti] x86/asm: Pad assembly functions with INT3 instructions David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180625131932.sge43esxdb5ejoxg@treble \
--to=jpoimboe@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=adobriyan@gmail.com \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=dvlasenk@redhat.com \
--cc=efault@gmx.de \
--cc=h.peter.anvin@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).