From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7E25C43144 for ; Mon, 25 Jun 2018 14:12:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6D7F125B25 for ; Mon, 25 Jun 2018 14:12:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6D7F125B25 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934324AbeFYOMt (ORCPT ); Mon, 25 Jun 2018 10:12:49 -0400 Received: from mx2.suse.de ([195.135.220.15]:54801 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934014AbeFYOMs (ORCPT ); Mon, 25 Jun 2018 10:12:48 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext-too.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 1313FADCC; Mon, 25 Jun 2018 14:12:47 +0000 (UTC) Date: Mon, 25 Jun 2018 16:12:46 +0200 From: Michal Hocko To: peter enderborg Cc: Tetsuo Handa , linux-mm@kvack.org, rientjes@google.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm,oom: Bring OOM notifier callbacks to outside of OOM killer. Message-ID: <20180625141246.GN28965@dhcp22.suse.cz> References: <1529493638-6389-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp> <20180620115531.GL13685@dhcp22.suse.cz> <3d27f26e-68ba-d3c0-9518-cebeb2689aec@sony.com> <20180625130756.GK28965@dhcp22.suse.cz> <9a14d554-6470-e0d6-19cc-1ecec17a47c7@sony.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9a14d554-6470-e0d6-19cc-1ecec17a47c7@sony.com> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 25-06-18 16:04:04, peter enderborg wrote: > On 06/25/2018 03:07 PM, Michal Hocko wrote: > > > On Mon 25-06-18 15:03:40, peter enderborg wrote: > >> On 06/20/2018 01:55 PM, Michal Hocko wrote: > >>> On Wed 20-06-18 20:20:38, Tetsuo Handa wrote: > >>>> Sleeping with oom_lock held can cause AB-BA lockup bug because > >>>> __alloc_pages_may_oom() does not wait for oom_lock. Since > >>>> blocking_notifier_call_chain() in out_of_memory() might sleep, sleeping > >>>> with oom_lock held is currently an unavoidable problem. > >>> Could you be more specific about the potential deadlock? Sleeping while > >>> holding oom lock is certainly not nice but I do not see how that would > >>> result in a deadlock assuming that the sleeping context doesn't sleep on > >>> the memory allocation obviously. > >> It is a mutex you are supposed to be able to sleep.  It's even exported. > > What do you mean? oom_lock is certainly not exported for general use. It > > is not local to oom_killer.c just because it is needed in other _mm_ > > code. > > > > It  is in the oom.h file include/linux/oom.h, if it that sensitive it should > be in mm/ and a documented note about the special rules. It is only used > in drivers/tty/sysrq.c and that be replaced by a help function in mm that > do the  oom stuff. Well, there are many things defined in kernel header files and not meant for wider use. Using random locks is generally discouraged I would say unless you are sure you know what you are doing. We could do some more work to hide internals for sure, though. > >>>> As a preparation for not to sleep with oom_lock held, this patch brings > >>>> OOM notifier callbacks to outside of OOM killer, with two small behavior > >>>> changes explained below. > >>> Can we just eliminate this ugliness and remove it altogether? We do not > >>> have that many notifiers. Is there anything fundamental that would > >>> prevent us from moving them to shrinkers instead? > >> @Hocko Do you remember the lowmemorykiller from android? Some things > >> might not be the right thing for shrinkers. > > Just that lmk did it wrong doesn't mean others have to follow. > > > If all you have is a hammer, everything looks like a nail. (I don’t argument that it was right) > But if you don’t have a way to interact with the memory system we will get attempts like lmk.  > Oom notifiers and vmpressure is for this task better than shrinkers. A lack of feature should be a trigger for a discussion rather than a quick hack that seems to work for a particular usecase and live out of tree, then get to staging and hope it will fix itself. Seriously, the kernel development is not a nail hammering. -- Michal Hocko SUSE Labs