From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Samuel Ortiz <sameo@linux.intel.com>,
"David S. Miller" <davem@davemloft.net>,
Steven Rostedt <rostedt@goodmis.org>,
Petr Mladek <pmladek@suse.com>,
syzkaller-bugs <syzkaller-bugs@googlegroups.com>,
linux-wireless@vger.kernel.org, netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
syzbot <syzbot+d29d18215e477cfbfbdd@syzkaller.appspotmail.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCH] NFC: llcp: fix nfc_llcp_send_ui_frame() lockup
Date: Tue, 26 Jun 2018 14:12:21 +0900 [thread overview]
Message-ID: <20180626051221.GC31439@jagdpanzerIV> (raw)
In-Reply-To: <CACT4Y+ZvLqzEwXgdB25MrmAS_j2_HsS8NFaJaMojzMV3prXypg@mail.gmail.com>
On (06/26/18 07:07), Dmitry Vyukov wrote:
[..]
> > #include <net/nfc/nfc.h>
> > @@ -755,7 +756,8 @@ int nfc_llcp_send_ui_frame(struct nfc_llcp_sock *sock, u8 ssap, u8 dsap,
> > pdu = nfc_alloc_send_skb(sock->dev, &sock->sk, MSG_DONTWAIT,
> > frag_len + LLCP_HEADER_SIZE, &err);
> > if (pdu == NULL) {
> > - pr_err("Could not allocate PDU\n");
> > + pr_err_ratelimited("Could not allocate PDU\n");
> > + cond_resched();
> > continue;
> > }
>
>
> But this thread is still in an infinite (unkillable?) loop? If yes, we
> are waiting for the next syzbot report ;)
The loop is still infinite, correct, but we have a preemption point now.
Sure, net people can come with a much better solution, I'll be happy to
scratch my patch.
-ss
next prev parent reply other threads:[~2018-06-26 5:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-26 4:41 [PATCH] NFC: llcp: fix nfc_llcp_send_ui_frame() lockup Sergey Senozhatsky
2018-06-26 5:07 ` Dmitry Vyukov
2018-06-26 5:12 ` Sergey Senozhatsky [this message]
2018-06-26 6:44 ` Eric Dumazet
2018-06-26 7:00 ` Sergey Senozhatsky
2018-06-26 14:17 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180626051221.GC31439@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=davem@davemloft.net \
--cc=dvyukov@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sameo@linux.intel.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=syzbot+d29d18215e477cfbfbdd@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).