From: Rob Herring <robh@kernel.org>
To: Taniya Das <tdas@codeaurora.org>
Cc: Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
Amit Nischal <anischal@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, Rohit Kumar <rohitkr@codeaurora.org>
Subject: Re: [PATCH 1/2] dt-bindings: clock: Introduce QCOM LPASS clock bindings
Date: Tue, 26 Jun 2018 13:53:36 -0600 [thread overview]
Message-ID: <20180626195336.GA25448@rob-hp-laptop> (raw)
In-Reply-To: <1528961943-12506-2-git-send-email-tdas@codeaurora.org>
On Thu, Jun 14, 2018 at 01:09:02PM +0530, Taniya Das wrote:
> Add device tree bindings for Low Power Audio subsystem clock controller for
> Qualcomm Technology Inc's SDM845 SoCs.
>
> Signed-off-by: Taniya Das <tdas@codeaurora.org>
> ---
> .../devicetree/bindings/clock/qcom,lpasscc.txt | 46 ++++++++++++++++++++++
> include/dt-bindings/clock/qcom,lpass-sdm845.h | 18 +++++++++
> 2 files changed, 64 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/qcom,lpasscc.txt
> create mode 100644 include/dt-bindings/clock/qcom,lpass-sdm845.h
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,lpasscc.txt b/Documentation/devicetree/bindings/clock/qcom,lpasscc.txt
> new file mode 100644
> index 0000000..16cabc4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,lpasscc.txt
> @@ -0,0 +1,46 @@
> +Qualcomm LPASS Clock Controller Binding
> +-----------------------------------------------
> +
> +Required properties :
> +- compatible : shall contain "qcom,sdm845-lpasscc"
> +- #clock-cells : from common clock binding, shall contain 1.
> +
> +Note that #address-cells, #size-cells, and ranges shall be present to ensure
> +the lpasscc can address the various lpass cc registers.
> +
> +Child Node Properties :
> +The Low Pass Audio clock controller would need to define the following child
> +nodes with the properties.
> +- compatible : shall contain all of the below for clocks in each LPASS domain
> + "qcom,sdm845-lpass-gcc",
> + "qcom,sdm845-lpass-cc",
> + "qcom,sdm845-lpass-qdsp6ss"
> +- reg : shall contain base register address and size,
I can't really see any reason to have these child nodes. Just put 3
entries in reg in the parent.
Rob
next prev parent reply other threads:[~2018-06-26 19:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 7:39 [PATCH 0/2] Add support for LPASS clock controller for SDM845 Taniya Das
2018-06-14 7:39 ` [PATCH 1/2] dt-bindings: clock: Introduce QCOM LPASS clock bindings Taniya Das
2018-06-26 19:53 ` Rob Herring [this message]
2018-06-14 7:39 ` [PATCH 2/2] clk: qcom: Add lpass clock controller driver for SDM845 Taniya Das
2018-06-14 10:38 ` kbuild test robot
2018-06-14 10:38 ` [RFC PATCH] clk: qcom: gcc_lpass_sway_clk can be static kbuild test robot
2018-06-18 14:40 ` [PATCH 2/2] clk: qcom: Add lpass clock controller driver for SDM845 Dan Carpenter
2018-09-11 17:00 [PATCH v4 0/2] Add support for LPASS clock controller " Taniya Das
2018-09-11 17:00 ` [PATCH 1/2] dt-bindings: clock: Introduce QCOM LPASS clock bindings Taniya Das
[not found] ` <20180917031811.GA11141@bogus>
2018-09-18 10:25 ` Taniya Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180626195336.GA25448@rob-hp-laptop \
--to=robh@kernel.org \
--cc=andy.gross@linaro.org \
--cc=anischal@codeaurora.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=rnayak@codeaurora.org \
--cc=rohitkr@codeaurora.org \
--cc=sboyd@kernel.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).