Hi Paul,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on pinctrl/devel]
[also build test ERROR on v4.18-rc2 next-20180627]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Paul-Cercueil/pinctrl-Add-core-function-pinmux_gpio_get_direction/20180627-201609
base:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
config: x86_64-randconfig-x002-201825 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers//pinctrl/core.c: In function 'pinctrl_gpio_get_direction':
>> drivers//pinctrl/core.c:873:8: error: implicit declaration of function 'pinmux_gpio_get_direction'; did you mean 'pinmux_gpio_direction'? [-Werror=implicit-function-declaration]
     ret = pinmux_gpio_get_direction(pctldev, range, pin);
           ^~~~~~~~~~~~~~~~~~~~~~~~~
           pinmux_gpio_direction
   cc1: some warnings being treated as errors

vim +873 drivers//pinctrl/core.c

   849	
   850	/**
   851	 * pinctrl_gpio_get_direction() - Get the direction (input/output) of a GPIO pin
   852	 * @gpio: the GPIO pin number from the GPIO subsystem number space
   853	 *
   854	 * This function should *ONLY* be used from gpiolib-based GPIO drivers,
   855	 * as part of their gpio_get_direction() semantics, platforms and individual
   856	 * drivers shall *NOT* touch pin control GPIO calls.
   857	 */
   858	int pinctrl_gpio_get_direction(unsigned int gpio)
   859	{
   860		struct pinctrl_dev *pctldev;
   861		struct pinctrl_gpio_range *range;
   862		int ret;
   863		int pin;
   864	
   865		ret = pinctrl_get_device_gpio_range(gpio, &pctldev, &range);
   866		if (ret)
   867			return ret;
   868	
   869		mutex_lock(&pctldev->mutex);
   870	
   871		/* Convert to the pin controllers number space */
   872		pin = gpio_to_pin(range, gpio);
 > 873		ret = pinmux_gpio_get_direction(pctldev, range, pin);
   874	
   875		mutex_unlock(&pctldev->mutex);
   876	
   877		return ret;
   878	}
   879	EXPORT_SYMBOL_GPL(pinctrl_gpio_get_direction);
   880	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation