From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8752C43141 for ; Thu, 28 Jun 2018 17:32:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B5E127759 for ; Thu, 28 Jun 2018 17:32:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B5E127759 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935813AbeF1Rcs (ORCPT ); Thu, 28 Jun 2018 13:32:48 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:52684 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934583AbeF1Rcr (ORCPT ); Thu, 28 Jun 2018 13:32:47 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 191CA40255D7; Thu, 28 Jun 2018 17:32:47 +0000 (UTC) Received: from kamzik.brq.redhat.com (unknown [10.43.2.160]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9C6FF21565E1; Thu, 28 Jun 2018 17:32:45 +0000 (UTC) Date: Thu, 28 Jun 2018 19:32:43 +0200 From: Andrew Jones To: Sudeep Holla Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, jeremy.linton@arm.com, ard.biesheuvel@linaro.org, shunyong.yang@hxt-semitech.com, yu.zheng@hxt-semitech.com, catalin.marinas@arm.com, will.deacon@arm.com Subject: Re: [PATCH] arm64: acpi: reenumerate topology ids Message-ID: <20180628173243.obydzakh2stfs26w@kamzik.brq.redhat.com> References: <20180628145128.10057-1-drjones@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180622 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Thu, 28 Jun 2018 17:32:47 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Thu, 28 Jun 2018 17:32:47 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'drjones@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 28, 2018 at 05:30:51PM +0100, Sudeep Holla wrote: > I am not sure if we can ever guarantee that DT and ACPI will get the > same ids whatever counter we use as it depends on the order presented in > the firmware(DT or ACPI). So I am not for generating ids for core and > threads in that way. I don't believe we have to guarantee that the exact (package,core,thread) triplet describing a PE with DT matches ACPI. We just need to guarantee that each triplet we select properly puts a PE in the same group as its peers. So, as long as we keep the grouping described by DT or ACPI, then the (package,core,thread) IDs assigned are pretty arbitrary. I could change the commit message to state we can generate IDs *like* DT does (i.e. with counters), even if they may not result in identical triplet to PE mappings. > > So I would like to keep it simple and just have this counters for > package ids as demonstrated in Shunyong's patch. > If we don't also handle cores when there are threads, then the cores will also end up having weird IDs. Thanks, drew