From: David Miller <davem@davemloft.net>
To: shakeelb@google.com
Cc: akpm@linux-foundation.org, hannes@cmpxchg.org,
vdavydov.dev@gmail.com, gthelen@google.com, guro@fb.com,
edumazet@google.com, ktkhai@virtuozzo.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v2] net, mm: account sock objects to kmemcg
Date: Fri, 29 Jun 2018 21:57:05 +0900 (KST) [thread overview]
Message-ID: <20180629.215705.881234148380578564.davem@davemloft.net> (raw)
In-Reply-To: <20180627221642.247448-1-shakeelb@google.com>
From: Shakeel Butt <shakeelb@google.com>
Date: Wed, 27 Jun 2018 15:16:42 -0700
> Currently the kernel accounts the memory for network traffic through
> mem_cgroup_[un]charge_skmem() interface. However the memory accounted
> only includes the truesize of sk_buff which does not include the size of
> sock objects. In our production environment, with opt-out kmem
> accounting, the sock kmem caches (TCP[v6], UDP[v6], RAW[v6], UNIX) are
> among the top most charged kmem caches and consume a significant amount
> of memory which can not be left as system overhead. So, this patch
> converts the kmem caches of all sock objects to SLAB_ACCOUNT.
>
> Signed-off-by: Shakeel Butt <shakeelb@google.com>
> Suggested-by: Eric Dumazet <edumazet@google.com>
> ---
> Changelog since v1:
> - Instead of specific sock kmem_caches, convert all sock kmem_caches to
> use SLAB_ACCOUNT.
Applied, thank you.
prev parent reply other threads:[~2018-06-29 12:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 22:16 [PATCH v2] net, mm: account sock objects to kmemcg Shakeel Butt
2018-06-28 14:52 ` Kirill Tkhai
2018-06-28 15:03 ` Eric Dumazet
2018-06-29 12:57 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180629.215705.881234148380578564.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=edumazet@google.com \
--cc=gthelen@google.com \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
--cc=shakeelb@google.com \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).