From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Nicholas Mc Guire <hofrat@osadl.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: faraday: add missing of_node_put()
Date: Fri, 29 Jun 2018 14:44:23 +0100 [thread overview]
Message-ID: <20180629134423.GF9643@red-moon> (raw)
In-Reply-To: <1529766899-1994-1-git-send-email-hofrat@osadl.org>
On Sat, Jun 23, 2018 at 05:14:59PM +0200, Nicholas Mc Guire wrote:
> The call to of_get_next_child() returns a node pointer with refcount
> incremented thus it must be explicitly decremented here in the error
> path and after the last usage.
>
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> Fixes: commit d3c68e0a7e34 ("PCI: faraday: Add Faraday Technology FTPCI100 PCI Host Bridge driver")
> ---
>
> Patch found my experimental coccinelle script
>
> Patch was compile tested with: gemini_defconfig (implies CONFIG_PCI_FTPCI100=y)
>
> Patch is against 4.18-rc1 (localversion-next is next-20180621)
>
> drivers/pci/controller/pci-ftpci100.c | 2 ++
> 1 file changed, 2 insertions(+)
Applied to pci/controller-fixes to be tentatively merged for -rc4,
thanks.
Lorenzo
> diff --git a/drivers/pci/controller/pci-ftpci100.c b/drivers/pci/controller/pci-ftpci100.c
> index a1ebe9e..20bb256 100644
> --- a/drivers/pci/controller/pci-ftpci100.c
> +++ b/drivers/pci/controller/pci-ftpci100.c
> @@ -355,11 +355,13 @@ static int faraday_pci_setup_cascaded_irq(struct faraday_pci *p)
> irq = of_irq_get(intc, 0);
> if (irq <= 0) {
> dev_err(p->dev, "failed to get parent IRQ\n");
> + of_node_put(intc);
> return irq ?: -EINVAL;
> }
>
> p->irqdomain = irq_domain_add_linear(intc, PCI_NUM_INTX,
> &faraday_pci_irqdomain_ops, p);
> + of_node_put(intc);
> if (!p->irqdomain) {
> dev_err(p->dev, "failed to create Gemini PCI IRQ domain\n");
> return -EINVAL;
> --
> 2.1.4
>
prev parent reply other threads:[~2018-06-29 13:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-23 15:14 [PATCH] PCI: faraday: add missing of_node_put() Nicholas Mc Guire
2018-06-26 7:21 ` Linus Walleij
2018-06-29 13:44 ` Lorenzo Pieralisi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180629134423.GF9643@red-moon \
--to=lorenzo.pieralisi@arm.com \
--cc=bhelgaas@google.com \
--cc=hofrat@osadl.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).