From: Mike Rapoport <rppt@linux.vnet.ibm.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Vineet Gupta <vgupta@synopsys.com>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arc/Kconfig: include mm/Kconfig inside "ARC system configuration"
Date: Fri, 29 Jun 2018 23:57:16 +0300 [thread overview]
Message-ID: <20180629205716.GG4799@rapoport-lnx> (raw)
In-Reply-To: <e18f80e1-fc59-9487-95eb-7cb6cda976c5@infradead.org>
On Fri, Jun 29, 2018 at 01:28:59PM -0700, Randy Dunlap wrote:
> On 06/29/2018 12:28 PM, Mike Rapoport wrote:
> > Hi Randy,
> >
> > On Fri, Jun 29, 2018 at 09:34:55AM -0700, Randy Dunlap wrote:
> >> On 06/29/2018 06:42 AM, Mike Rapoport wrote:
> >>> Otherwise mm configuration options show up in the top level menu.
> >>>
> >>> Signed-off-by: Mike Rapoport <rppt@linux.vnet.ibm.com>
> >>
> >> Hi Mike,
> >>
> >> In which config tool does this matter?
> >>
> >> For xconfig, it seems to me that this patch hides the MM menu, whereas
> >> before this patch, the MM menu is easy to find (although it could
> >> use some kind of heading).
> >
> > With xconfig the menu gets into the top right pane when you click on "ARC
> > architecture configuration", similar to what one gets on x86 with
> > "Processor type and features" or "Kernel features" on ARM.
> >
> > With menuconfig it looks a bit more prominent, note that mm options are
> > between "ARC Architecture Configuration" and "Networking support":
>
> I know. I ran all 4 of menuconfig, nconfig, xconfig, and gconfig.
>
> I would prefer to see Memory Management options have its own top-level
> menu, but that's a different patch. Then menuconfig would look like this:
>
>
>
> │ │ *** Compiler: arc-linux-gcc (GCC) 8.1.0 *** │ │
> │ │ General setup ---> │ │
> │ │ [*] Enable loadable module support ---> │ │
> │ │ [*] Enable the block layer ---> │ │
> │ │ ARC Architecture Configuration ---> │ │
> │ │ Memory Management options ---> │ │
> │ │ (11) Maximum zone order │ │
> │ │ [*] Networking support ---> │ │
> │ │ Device Drivers ---> │ │
> │ │ Bus Support --->
>
>
> but that "Maximum zone order" needs to be moved or taken care of somehow.
I think that would be something like this:
diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig
index e81bcd271be7..44a20141639a 100644
--- a/arch/arc/Kconfig
+++ b/arch/arc/Kconfig
@@ -556,12 +556,14 @@ endmenu
endmenu # "ARC Architecture Configuration"
+menu "Memory Management"
source "mm/Kconfig"
config FORCE_MAX_ZONEORDER
int "Maximum zone order"
default "12" if ARC_HUGEPAGE_16M
default "11"
+endmenu # "Memory Management"
source "net/Kconfig"
source "drivers/Kconfig"
>
> [snip]
>
> >
> >
> >
> >>> default "12" if ARC_HUGEPAGE_16M
> >>> default "11"
> >>>
> >>> +endmenu # "ARC Architecture Configuration"
> >>> +
> >>> source "net/Kconfig"
> >>> source "drivers/Kconfig"
>
>
> thanks,
> --
> ~Randy
>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2018-06-29 20:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 13:42 [PATCH] arc/Kconfig: include mm/Kconfig inside "ARC system configuration" Mike Rapoport
2018-06-29 16:34 ` Randy Dunlap
2018-06-29 19:28 ` Mike Rapoport
2018-06-29 20:28 ` Randy Dunlap
2018-06-29 20:37 ` Vineet Gupta
2018-06-29 20:57 ` Mike Rapoport [this message]
2018-06-29 21:12 ` Vineet Gupta
2018-06-30 6:08 ` Randy Dunlap
2018-06-29 20:16 ` Vineet Gupta
2018-07-02 13:20 ` Christoph Hellwig
2018-07-02 14:29 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180629205716.GG4799@rapoport-lnx \
--to=rppt@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=vgupta@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).