From: Shawn Guo <shawnguo@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>,
nikita.yoush@yandex.ru, Mark Rutland <mark.rutland@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Andrey Gusakov <andrey.gusakov@cogentembedded.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
Chris Healy <cphealy@gmail.com>,
Lucas Stach <l.stach@pengutronix.de>
Subject: Re: [1/3] ARM: dts: imx51-zii-common: create common include dtsi
Date: Sun, 1 Jul 2018 16:21:21 +0800 [thread overview]
Message-ID: <20180701082119.GH4348@dragon> (raw)
In-Reply-To: <CAOMZO5B5PS7a6SFfzX915AkRoDpeFVV7P0hrG9A51yWRFy5X_w@mail.gmail.com>
On Wed, Jun 27, 2018 at 02:00:11PM -0300, Fabio Estevam wrote:
> On Wed, Jun 27, 2018 at 1:46 PM, Andrey Smirnov
> <andrew.smirnov@gmail.com> wrote:
>
> > We are now starting to give Andrey Gusakov conflicting
> > recommendations. For the sake of moving forward, can we agree that
> > this and similar comments are relatively minor and defer to the
> > maintainers to make a call which way to go?
> > This way Andrey has a clear way on how to move forward with this set.
>
> The approach in this patched looked fine to me as well.
>
> Maybe we can have some feedback from Shawn?
I'm overall fine with the approach as well. But I agree with Nikita's
comment that having pinctrl definition and usage spread in different
files makes reader's life harder. So I would suggest that we have the
following properties in imx51-zii-rdu1.dts as well.
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_swi2c>;
Shawn
next prev parent reply other threads:[~2018-07-01 8:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 17:44 [PATCH 0/3] ARM: dts: imx: add two ZII boards Andrey Gusakov
2018-06-21 17:44 ` [PATCH 1/3] ARM: dts: imx51-zii-common: create common include dtsi Andrey Gusakov
2018-06-26 22:08 ` Fabio Estevam
2018-06-27 7:11 ` [1/3] " Nikita Yushchenko
2018-06-27 16:46 ` Andrey Smirnov
2018-06-27 16:59 ` Nikita Yushchenko
2018-06-27 17:33 ` Andrey Smirnov
2018-06-27 17:00 ` Fabio Estevam
2018-07-01 8:21 ` Shawn Guo [this message]
2018-07-02 8:21 ` [PATCH 1/3] " Andrey Gusakov
2018-06-21 17:44 ` [PATCH 2/3] ARM: dts: imx: add ZII SCU2 ESB board Andrey Gusakov
2018-06-26 15:45 ` Fabio Estevam
2018-07-01 8:25 ` Shawn Guo
2018-06-21 17:45 ` [PATCH 3/3] ARM: dts: imx: add ZII SCU2 Mezz board Andrey Gusakov
2018-06-26 15:46 ` Fabio Estevam
2018-07-01 8:44 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180701082119.GH4348@dragon \
--to=shawnguo@kernel.org \
--cc=andrew.smirnov@gmail.com \
--cc=andrey.gusakov@cogentembedded.com \
--cc=cphealy@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nikita.yoush@yandex.ru \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).