From: Herbert Xu <herbert@gondor.apana.org.au>
To: Rishabh Bhatnagar <rishabhb@codeaurora.org>
Cc: neilb@suse.com, tgraf@suug.ch, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib: rhashtable: Correct self-assignment in rhashtable.c
Date: Mon, 2 Jul 2018 15:06:28 +0800 [thread overview]
Message-ID: <20180702070628.lhi63kcgcfwj64y4@gondor.apana.org.au> (raw)
In-Reply-To: <1530493906-19711-1-git-send-email-rishabhb@codeaurora.org>
On Sun, Jul 01, 2018 at 06:11:46PM -0700, Rishabh Bhatnagar wrote:
> In file lib/rhashtable.c line 777, skip variable is assigned to
> itself. The following error was observed:
>
> lib/rhashtable.c:777:41: warning: explicitly assigning value of
> variable of type 'int' to itself [-Wself-assign] error, forbidden
> warning: rhashtable.c:777
> This error was found when compiling with Clang 6.0. Change it to iter->skip.
>
> Change-Id: I5abd1ce5ba76737a73bd6eca94b07b1bd5267523
> Signed-off-by: Rishabh Bhatnagar <rishabhb@codeaurora.org>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2018-07-02 7:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 1:11 [PATCH] lib: rhashtable: Correct self-assignment in rhashtable.c Rishabh Bhatnagar
2018-07-02 1:32 ` NeilBrown
2018-07-02 7:06 ` Herbert Xu [this message]
2018-07-02 7:07 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180702070628.lhi63kcgcfwj64y4@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.com \
--cc=rishabhb@codeaurora.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).