On Sat, Jun 30, 2018 at 07:22:41PM +0200, Jerome Brunet wrote: > + switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) { > + case SND_SOC_DAIFMT_I2S: > + case SND_SOC_DAIFMT_LEFT_J: > + break; These two modes are not the same so either there should be some different handling to select between them or one shouldn't be supported. Otherwise this looks good.