From: Mark Brown <broonie@kernel.org>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] ASoC: es7241: add es7241 codec support
Date: Mon, 2 Jul 2018 11:20:21 +0100 [thread overview]
Message-ID: <20180702102021.GG18211@sirena.org.uk> (raw)
In-Reply-To: <1530526503.2900.144.camel@baylibre.com>
[-- Attachment #1: Type: text/plain, Size: 912 bytes --]
On Mon, Jul 02, 2018 at 12:15:03PM +0200, Jerome Brunet wrote:
> On Mon, 2018-07-02 at 11:12 +0100, Mark Brown wrote:
> > On Sat, Jun 30, 2018 at 07:22:41PM +0200, Jerome Brunet wrote:
> > > + switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
> > > + case SND_SOC_DAIFMT_I2S:
> > > + case SND_SOC_DAIFMT_LEFT_J:
> > > + break;
> > These two modes are not the same so either there should be some
> > different handling to select between them or one shouldn't be supported.
> Actually, the difference is provided with some pull-up/pull-down resistor.
> There no way to set this up in SW, AFAIK.
> So the driver shall accept both and trust we are not doing anything crazy
It at least needs a comment as this is obviously dodgy code. Ideally
there'd be a DT property saying which mode was selected on a given board
so if we ever get round to doing automatic configuration of formats the
driver will be able to cope.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2018-07-02 10:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-30 17:22 [PATCH v2 0/2] ASoC: add es7241 support Jerome Brunet
2018-06-30 17:22 ` [PATCH v2 1/2] ASoC: es7241: add dt-bindings documentation for the es7241 adc Jerome Brunet
2018-07-02 10:06 ` Mark Brown
2018-06-30 17:22 ` [PATCH v2 2/2] ASoC: es7241: add es7241 codec support Jerome Brunet
2018-07-02 10:12 ` Mark Brown
2018-07-02 10:15 ` Jerome Brunet
2018-07-02 10:20 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180702102021.GG18211@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=jbrunet@baylibre.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).