linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: linux-arm-kernel@lists.infradead.org, will.deacon@arm.com
Cc: linux-kernel@vger.kernel.org, catalin.marinas@arm.com,
	dave.martin@arm.com, hch@infradead.org, james.morse@arm.com,
	linux@dominikbrodowski.net, linux-fsdevel@vger.kernel.org,
	marc.zyngier@arm.com, mark.rutland@arm.com,
	viro@zeniv.linux.org.uk
Subject: [PATCHv4 05/19] arm64: move sve_user_{enable,disable} to <asm/fpsimd.h>
Date: Mon,  2 Jul 2018 12:04:01 +0100	[thread overview]
Message-ID: <20180702110415.10465-6-mark.rutland@arm.com> (raw)
In-Reply-To: <20180702110415.10465-1-mark.rutland@arm.com>

In subsequent patches, we'll want to make use of sve_user_enable() and
sve_user_disable() outside of kernel/fpsimd.c. Let's move these to
<asm/fpsimd.h> where we can make use of them.

To avoid ifdeffery in sequences like:

if (system_supports_sve() && some_condition)
	sve_user_disable();

... empty stubs are provided when support for SVE is not enabled. Note
that system_supports_sve() contains as IS_ENABLED(CONFIG_ARM64_SVE), so
the sve_user_disable() call should be optimized away entirely when
CONFIG_ARM64_SVE is not selected.

To ensure that this is the case, the stub definitions contain a
BUILD_BUG(), as we do for other stubs for which calls should always be
optimized away when the relevant config option is not selected.

At the same time, the include list of <asm/fpsimd.h> is sorted while
adding <asm/sysreg.h>.

Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Reviewed-by: Dave Martin <dave.martin@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
---
 arch/arm64/include/asm/fpsimd.h | 17 ++++++++++++++++-
 arch/arm64/kernel/fpsimd.c      | 10 ----------
 2 files changed, 16 insertions(+), 11 deletions(-)

diff --git a/arch/arm64/include/asm/fpsimd.h b/arch/arm64/include/asm/fpsimd.h
index fa92747a49c8..dd1ad3950ef5 100644
--- a/arch/arm64/include/asm/fpsimd.h
+++ b/arch/arm64/include/asm/fpsimd.h
@@ -16,13 +16,15 @@
 #ifndef __ASM_FP_H
 #define __ASM_FP_H
 
-#include <asm/ptrace.h>
 #include <asm/errno.h>
+#include <asm/ptrace.h>
 #include <asm/processor.h>
 #include <asm/sigcontext.h>
+#include <asm/sysreg.h>
 
 #ifndef __ASSEMBLY__
 
+#include <linux/build_bug.h>
 #include <linux/cache.h>
 #include <linux/init.h>
 #include <linux/stddef.h>
@@ -102,6 +104,16 @@ extern int sve_set_vector_length(struct task_struct *task,
 extern int sve_set_current_vl(unsigned long arg);
 extern int sve_get_current_vl(void);
 
+static inline void sve_user_disable(void)
+{
+	sysreg_clear_set(cpacr_el1, CPACR_EL1_ZEN_EL0EN, 0);
+}
+
+static inline void sve_user_enable(void)
+{
+	sysreg_clear_set(cpacr_el1, 0, CPACR_EL1_ZEN_EL0EN);
+}
+
 /*
  * Probing and setup functions.
  * Calls to these functions must be serialised with one another.
@@ -128,6 +140,9 @@ static inline int sve_get_current_vl(void)
 	return -EINVAL;
 }
 
+static inline void sve_user_disable(void) { BUILD_BUG(); }
+static inline void sve_user_enable(void) { BUILD_BUG(); }
+
 static inline void sve_init_vq_map(void) { }
 static inline void sve_update_vq_map(void) { }
 static inline int sve_verify_vq_map(void) { return 0; }
diff --git a/arch/arm64/kernel/fpsimd.c b/arch/arm64/kernel/fpsimd.c
index a98a7f96aff1..58c53bc96928 100644
--- a/arch/arm64/kernel/fpsimd.c
+++ b/arch/arm64/kernel/fpsimd.c
@@ -159,16 +159,6 @@ static void sve_free(struct task_struct *task)
 	__sve_free(task);
 }
 
-static void sve_user_disable(void)
-{
-	sysreg_clear_set(cpacr_el1, CPACR_EL1_ZEN_EL0EN, 0);
-}
-
-static void sve_user_enable(void)
-{
-	sysreg_clear_set(cpacr_el1, 0, CPACR_EL1_ZEN_EL0EN);
-}
-
 /*
  * TIF_SVE controls whether a task can use SVE without trapping while
  * in userspace, and also the way a task's FPSIMD/SVE state is stored
-- 
2.11.0


  parent reply	other threads:[~2018-07-02 11:04 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-02 11:03 [PATCHv4 00/19] arm64: invoke syscalls with pt_regs Mark Rutland
2018-07-02 11:03 ` [PATCHv4 01/19] arm64: consistently use unsigned long for thread flags Mark Rutland
2018-07-02 11:03 ` [PATCHv4 02/19] arm64: move SCTLR_EL{1,2} assertions to <asm/sysreg.h> Mark Rutland
2018-07-02 11:03 ` [PATCHv4 03/19] arm64: kill config_sctlr_el1() Mark Rutland
2018-07-02 11:04 ` [PATCHv4 04/19] arm64: kill change_cpacr() Mark Rutland
2018-07-02 11:04 ` Mark Rutland [this message]
2018-07-02 11:04 ` [PATCHv4 06/19] arm64: remove sigreturn wrappers Mark Rutland
2018-07-02 11:04 ` [PATCHv4 07/19] arm64: convert raw syscall invocation to C Mark Rutland
2018-07-02 11:04 ` [PATCHv4 08/19] arm64: convert syscall trace logic " Mark Rutland
2018-07-02 11:04 ` [PATCHv4 09/19] arm64: convert native/compat syscall entry " Mark Rutland
2018-07-02 11:04 ` [PATCHv4 10/19] arm64: don't restore GPRs when context tracking Mark Rutland
2018-07-02 11:04 ` [PATCHv4 11/19] arm64: don't reload GPRs after apply_ssbd Mark Rutland
2018-07-06 16:38   ` Will Deacon
2018-07-09 14:21     ` Mark Rutland
2018-07-10 10:37       ` Dave Martin
2018-07-10 17:33         ` Will Deacon
2018-07-11  9:46           ` Mark Rutland
2018-07-02 11:04 ` [PATCHv4 12/19] arm64: zero GPRs upon entry from EL0 Mark Rutland
2018-07-02 11:04 ` [PATCHv4 13/19] kernel: add ksys_personality() Mark Rutland
2018-07-02 11:04 ` [PATCHv4 14/19] kernel: add kcompat_sys_{f,}statfs64() Mark Rutland
2018-07-02 11:04 ` [PATCHv4 15/19] arm64: remove in-kernel call to sys_personality() Mark Rutland
2018-07-02 11:04 ` [PATCHv4 16/19] arm64: use {COMPAT,}SYSCALL_DEFINE0 for sigreturn Mark Rutland
2018-07-02 11:04 ` [PATCHv4 17/19] arm64: use SYSCALL_DEFINE6() for mmap Mark Rutland
2018-07-02 11:04 ` [PATCHv4 18/19] arm64: convert compat wrappers to C Mark Rutland
2018-07-02 11:04 ` [PATCHv4 19/19] arm64: implement syscall wrappers Mark Rutland
2018-07-06 16:42 ` [PATCHv4 00/19] arm64: invoke syscalls with pt_regs Will Deacon
2018-07-10 10:39 ` Will Deacon
2018-07-11 10:47   ` Mark Rutland
2018-07-11 12:27     ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180702110415.10465-6-mark.rutland@arm.com \
    --to=mark.rutland@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=dave.martin@arm.com \
    --cc=hch@infradead.org \
    --cc=james.morse@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@dominikbrodowski.net \
    --cc=marc.zyngier@arm.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).