From: Thierry Reding <thierry.reding@gmail.com>
To: Mikko Perttunen <mperttunen@nvidia.com>
Cc: jassisinghbrar@gmail.com, gregkh@linuxfoundation.org,
jonathanh@nvidia.com, devicetree@vger.kernel.org,
linux-serial@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 5/8] mailbox: tegra-hsp: Add support for shared mailboxes
Date: Mon, 2 Jul 2018 15:13:00 +0200 [thread overview]
Message-ID: <20180702131300.GG13096@ulmo> (raw)
In-Reply-To: <20180702114033.15654-6-mperttunen@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1319 bytes --]
On Mon, Jul 02, 2018 at 02:40:30PM +0300, Mikko Perttunen wrote:
> The Tegra HSP block supports 'shared mailboxes' that are simple 32-bit
> registers consisting of a FULL bit in MSB position and 31 bits of data.
> The hardware can be configured to trigger interrupts when a mailbox
> is empty or full. Add support for these shared mailboxes to the HSP
> driver.
>
> The initial use for the mailboxes is the Tegra Combined UART. For this
> purpose, we use interrupts to receive data, and spinning to wait for
> the transmit mailbox to be emptied to minimize unnecessary overhead.
>
> Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
> Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
> ---
>
> Notes:
> v3:
> - Added define HSP_INT0_IE_FULL_SHIFT
> - Added Jon's Reviewed-by
>
> v2:
> - Added defines for some register fields
> - Simplified bit looping logic in interrupt handler
> - Changed write done polling to use readl_poll_timeout
> - Removed unnecessary zero assignments
> - Fixed two error cases in probe to do proper cleanup
>
> drivers/mailbox/tegra-hsp.c | 211 +++++++++++++++++++++++++++++++++++++++-----
> 1 file changed, 191 insertions(+), 20 deletions(-)
Looks good to me:
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-07-02 13:13 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 11:40 [PATCH v3 0/8] Tegra Combined UART driver Mikko Perttunen
2018-07-02 11:40 ` [PATCH v3 1/8] dt-bindings: tegra186-hsp: Add shared interrupts Mikko Perttunen
2018-07-02 12:37 ` Thierry Reding
2018-07-02 11:40 ` [PATCH v3 2/8] dt-bindings: serial: Add bindings for nvidia,tegra194-tcu Mikko Perttunen
2018-07-02 12:51 ` Thierry Reding
2018-07-02 11:40 ` [PATCH v3 3/8] mailbox: Add transmit done by blocking option Mikko Perttunen
2018-07-02 13:09 ` Thierry Reding
2018-07-10 15:49 ` Thierry Reding
2018-08-03 12:54 ` Jassi Brar
2018-08-04 10:45 ` Mikko Perttunen
2018-08-08 11:38 ` Mikko Perttunen
2018-08-08 14:10 ` Jassi Brar
2018-08-08 14:34 ` Mikko Perttunen
2018-08-08 14:39 ` Jassi Brar
2018-08-08 14:46 ` Mikko Perttunen
2018-08-09 8:49 ` Mikko Perttunen
2018-08-09 9:26 ` Jassi Brar
2018-07-02 11:40 ` [PATCH v3 4/8] mailbox: tegra-hsp: Refactor in preparation of mailboxes Mikko Perttunen
2018-07-02 13:12 ` Thierry Reding
2018-07-02 11:40 ` [PATCH v3 5/8] mailbox: tegra-hsp: Add support for shared mailboxes Mikko Perttunen
2018-07-02 13:13 ` Thierry Reding [this message]
2018-07-02 11:40 ` [PATCH v3 6/8] serial: Add Tegra Combined UART driver Mikko Perttunen
2018-07-02 13:18 ` Thierry Reding
2018-07-02 13:30 ` Mikko Perttunen
2018-07-02 13:47 ` Thierry Reding
2018-07-03 6:40 ` Mikko Perttunen
2018-07-02 11:40 ` [PATCH v3 7/8] arm64: tegra: Add nodes for tcu on Tegra194 Mikko Perttunen
2018-07-02 11:40 ` [PATCH v3 8/8] arm64: tegra: Mark tcu as primary serial port on Tegra194 P2888 Mikko Perttunen
2018-07-02 14:03 ` [PATCH v3 0/8] Tegra Combined UART driver Thierry Reding
2018-07-02 14:07 ` Greg KH
2018-07-02 14:17 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180702131300.GG13096@ulmo \
--to=thierry.reding@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jassisinghbrar@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).