From: Catalin Marinas <catalin.marinas@arm.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Laura Abbott <labbott@redhat.com>,
will.deacon@arm.com, Kees Cook <keescook@chromium.org>,
kernel-hardening@lists.openwall.com,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
linux-kernel@vger.kernel.org, james.morse@arm.com,
linux-arm-kernel@lists.infradead.org, alex.popov@linux.com
Subject: Re: [PATCH] arm64: Clear the stack
Date: Tue, 3 Jul 2018 16:03:49 +0100 [thread overview]
Message-ID: <20180703150349.fndcq7h5hl3mtain@armageddon.cambridge.arm.com> (raw)
In-Reply-To: <20180703121440.v4olvwqb3ykgt5fm@lakrids.cambridge.arm.com>
On Tue, Jul 03, 2018 at 01:14:41PM +0100, Mark Rutland wrote:
> On Mon, Jul 02, 2018 at 11:48:05AM -0700, Laura Abbott wrote:
> > On 07/02/2018 06:02 AM, Alexander Popov wrote:
> > > On 29.06.2018 22:05, Laura Abbott wrote:
> > > > Implementation of stackleak based heavily on the x86 version
> > > >
> > > > Signed-off-by: Laura Abbott <labbott@redhat.com>
> > > > ---
> > > > Changes since last time:
> > > > - Minor name change in entry.S
> > > > - Converted to use the generic interfaces so there's minimal additions.
> > > > - Added the fast syscall path.
> > > > - Addition of on_thread_stack and current_top_of_stack
> > > > - Disable stackleak on hyp per suggestion
> > > > - Added a define for check_alloca. I'm still not sure about keeping it
> > > > since the x86 version got reworked?
> > > >
> > > > I've mostly kept this as one patch with a minimal commit text. I can
> > > > split it up and elaborate more before final merging.
> > > > ---
>
> [...]
>
> > > > diff --git a/arch/arm64/kernel/entry.S b/arch/arm64/kernel/entry.S
> > > > index ec2ee720e33e..31c9da7d401e 100644
> > > > --- a/arch/arm64/kernel/entry.S
> > > > +++ b/arch/arm64/kernel/entry.S
> > > > @@ -401,6 +401,11 @@ tsk .req x28 // current thread_info
> > > > .text
> > > > + .macro stackleak_erase
> > >
> > > Could you rename the macro to STACKLEAK_ERASE for similarity with x86?
> > >
> >
> > Mark Rutland had previously asked for this to be lowercase.
> > I really don't care one way or the other so I'll defer to
> > someone else to have the final word.
>
> Will, Catalin, could you chime in either way?
>
> I'd previously asked for lower-case for consistency with our other
> assembly macros.
I'd keep it lowercase as the other arm64 macros in this file.
--
Catalin
next prev parent reply other threads:[~2018-07-03 15:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 19:05 [PATCH] arm64: Clear the stack Laura Abbott
2018-06-29 19:47 ` Kees Cook
2018-06-29 20:19 ` Kees Cook
2018-06-29 20:22 ` Laura Abbott
2018-06-29 20:25 ` Kees Cook
2018-07-02 9:59 ` Will Deacon
2018-07-02 17:29 ` Kees Cook
2018-07-04 14:04 ` Will Deacon
2018-07-02 13:02 ` Alexander Popov
2018-07-02 18:48 ` Laura Abbott
2018-07-03 12:14 ` Mark Rutland
2018-07-03 15:03 ` Catalin Marinas [this message]
2018-07-03 20:38 ` Alexander Popov
2018-07-17 22:58 ` Laura Abbott
2018-07-19 10:41 ` Mark Rutland
2018-07-12 0:05 ` Kees Cook
2018-07-12 12:10 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180703150349.fndcq7h5hl3mtain@armageddon.cambridge.arm.com \
--to=catalin.marinas@arm.com \
--cc=alex.popov@linux.com \
--cc=ard.biesheuvel@linaro.org \
--cc=james.morse@arm.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=labbott@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).