From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEDB0C6778C for ; Tue, 3 Jul 2018 16:45:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 960EC23C19 for ; Tue, 3 Jul 2018 16:45:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 960EC23C19 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934028AbeGCQpI (ORCPT ); Tue, 3 Jul 2018 12:45:08 -0400 Received: from mail-yw0-f196.google.com ([209.85.161.196]:34073 "EHLO mail-yw0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932520AbeGCQpH (ORCPT ); Tue, 3 Jul 2018 12:45:07 -0400 Received: by mail-yw0-f196.google.com with SMTP id j68-v6so928465ywg.1; Tue, 03 Jul 2018 09:45:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QwifxOs+z0bbOD30neLcaVfeEjxXWfUWFikiYksd6OU=; b=YYduuPs1QgliOLLmh4P216j//YlsGJE8ug7vdgWQqZDEDaMrfOCyLFxYl3HjkMZAFp G+eDa8yYEtxafedzOOqpEvbrzSvPh/59HjNbO3b0HC3zZU/ft8qsJ6xoWsYydlQFTc2V T0FkaxbhPYqDynQS5q2v4jiyLAlnYYXewi2irzh93Nk1cb9cwD84DctuC0L9PFbpxgIJ B5QdunJDXYRw5sU0Dk0O1jSjbS3HywRMOOwvknTKAr3CJyjnRUpuFclVHJq1GjwyYyRD NZDMROy0JSscBJmVMBi+DWhn4KJF6kKI6KLeV9+68G0mZXoTFVBjJcMxVc5dCMx58eJi 3rqA== X-Gm-Message-State: APt69E31dfdoyIFqNIdNYzOx9yVOZ06uH2p5kcdS5i9HEBe4kEdnwz+z Mi/1L8H/RvNc3ckHQEoNbjKuQAs= X-Google-Smtp-Source: AAOMgpeSSidBsCwflqmP1JRPg/26ftUCLl7WTZ/z+h8VF0mXIKMS+LepT/p81PLdmCB6xmaqNoxqCQ== X-Received: by 2002:a81:a9c6:: with SMTP id g189-v6mr14561712ywh.72.1530636306380; Tue, 03 Jul 2018 09:45:06 -0700 (PDT) Received: from localhost (24-223-123-72.static.usa-companies.net. [24.223.123.72]) by smtp.gmail.com with ESMTPSA id k64-v6sm607431ywb.7.2018.07.03.09.45.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 03 Jul 2018 09:45:05 -0700 (PDT) Date: Tue, 3 Jul 2018 10:45:03 -0600 From: Rob Herring To: Tomer Maimon Cc: mark.rutland@arm.com, jdelvare@suse.com, linux@roeck-us.net, avifishman70@gmail.com, yuenn@google.com, brendanhiggins@google.com, venture@google.com, joel@jms.id.au, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, openbmc@lists.ozlabs.org Subject: Re: [PATCH v7 1/2] dt-binding: hwmon: Add NPCM7xx PWM and Fan controller documentation Message-ID: <20180703164503.GA25357@rob-hp-laptop> References: <20180703094701.255662-1-tmaimon77@gmail.com> <20180703094701.255662-2-tmaimon77@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180703094701.255662-2-tmaimon77@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 03, 2018 at 12:47:00PM +0300, Tomer Maimon wrote: > Added device tree binding documentation for Nuvoton BMC > NPCM7xx Pulse Width Modulation (PWM) and Fan tach controller. > The PWM controller can support upto 8 PWM output ports. > The Fan tach controller can support upto 16 tachometer inputs. > > Signed-off-by: Tomer Maimon > --- > .../devicetree/bindings/hwmon/npcm750-pwm-fan.txt | 87 ++++++++++++++++++++++ > 1 file changed, 87 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/npcm750-pwm-fan.txt > > diff --git a/Documentation/devicetree/bindings/hwmon/npcm750-pwm-fan.txt b/Documentation/devicetree/bindings/hwmon/npcm750-pwm-fan.txt > new file mode 100644 > index 000000000000..c56d72d03717 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/npcm750-pwm-fan.txt > @@ -0,0 +1,87 @@ > +Nuvoton NPCM7xx PWM and Fan Tacho controller device > + > +The NPCM7xx has two identical Pulse-width modulation (PWM) controller modules, > +Each PWM module has four PWM controller outputs, Totally 8 PWM controller outputs. Kind of sounds like this should be 2 nodes then? > + > +The NPCM7xx has eight identical Fan tachometer controller modules, > +Each Fan module has two Fan controller inputs, Totally 16 Fan controller inputs. > + > +Required properties for pwm-fan node > +- #address-cells : should be 1. > +- #size-cells : should be 0. > +- compatible : "nuvoton,npcm750-pwm-fan" for Poleg NPCM7XX. > +- reg : specifies physical base address and size of the registers. > +- reg-names : must contain: > + * "pwm" for the PWM registers. > + * "fan" for the Fan registers. > +- clocks : phandle of reference clocks. > +- clock-names : must contain > + * "clk_apb3" for clock of PWM controller. > + * "clk_apb4" for clock of Fan controller. The "clk_" part is redundant. Also, this should be the names of the clocks in the module, not the name of the source clocks. It seems like these may be the latter? > +- interrupts : contain the Fan interrupts with flags for falling edge. > +- pinctrl-names : a pinctrl state named "default" must be defined. > +- pinctrl-0 : phandle referencing pin configuration of the PWM and Fan > + controller ports. > + > +fan subnode format: > +=================== > +Under fan subnode can be upto 8 child nodes, each child node representing a fan. > +Each fan subnode must have one PWM channel and atleast one Fan tach channel. > + > +For PWM channel can be configured cooling-levels to create cooling device. > +Cooling device could be bound to a thermal zone for the thermal control. > + > +Required properties for each child node: > +- reg : specify the PWM output channel. > + integer value in the range 0 through 7, that represent > + the PWM channel number that used. > + > +- fan-tach-ch : specify the Fan tach input channel. > + integer value in the range 0 through 15, that represent > + the fan tach channel number that used. > + > + At least one Fan tach input channel is required > + > +Optional property for each child node: > +- cooling-levels: PWM duty cycle values in a range from 0 to 255 > + which correspond to thermal cooling states. > + > +Examples: > + > +pwm_fan:pwm-fan-controller@103000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "nuvoton,npcm750-pwm-fan"; > + reg = <0x103000 0x2000>, > + <0x180000 0x8000>; > + reg-names = "pwm", "fan"; > + clocks = <&clk NPCM7XX_CLK_APB3>, > + <&clk NPCM7XX_CLK_APB4>; > + clock-names = "clk_apb3","clk_apb4"; > + interrupts = , > + , > + , > + , > + , > + , > + , > + ; > + pinctrl-names = "default"; > + pinctrl-0 = <&pwm0_pins &pwm1_pins &pwm2_pins > + &fanin0_pins &fanin1_pins &fanin2_pins > + &fanin3_pins &fanin4_pins>; > + fan@0 { > + reg = <0x00>; > + fan-ch = /bits/ 8 <0x00 0x01>; Doesn't match the doc. > + cooling-levels = <127 255>; > + }; > + fan@1 { > + reg = <0x01>; > + fan-ch = /bits/ 8 <0x02 0x03>; > + }; > + fan@2 { > + reg = <0x02>; > + fan-ch = /bits/ 8 <0x04>; > + }; > + > +}; > \ No newline at end of file > -- > 2.14.1 >