From: Rob Herring <robh@kernel.org>
To: Guodong Xu <guodong.xu@linaro.org>
Cc: vkoul@kernel.org, mark.rutland@arm.com, dan.j.williams@intel.com,
liyu65@hisilicon.com, suzhuangluan@hisilicon.com,
xuhongtao8@hisilicon.com, zhongkaihua@huawei.com,
xuezhiliang@hisilicon.com, xupeng7@huawei.com,
sunliang10@huawei.com, fengbaopeng@hisilicon.com,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: k3dma: add optional property dma_min_chan
Date: Tue, 3 Jul 2018 12:54:42 -0600 [thread overview]
Message-ID: <20180703185442.GA18008@rob-hp-laptop> (raw)
In-Reply-To: <20180622032416.20133-2-guodong.xu@linaro.org>
On Fri, Jun 22, 2018 at 11:24:14AM +0800, Guodong Xu wrote:
> From: Li Yu <liyu65@hisilicon.com>
>
> Add optional property dma_min_chan for k3dma.
>
> Signed-off-by: Li Yu <liyu65@hisilicon.com>
> ---
> Documentation/devicetree/bindings/dma/k3dma.txt | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/dma/k3dma.txt b/Documentation/devicetree/bindings/dma/k3dma.txt
> index 4945aeac4dc4..2fa1370c3173 100644
> --- a/Documentation/devicetree/bindings/dma/k3dma.txt
> +++ b/Documentation/devicetree/bindings/dma/k3dma.txt
> @@ -12,6 +12,11 @@ Required properties:
> have specific request line
> - clocks: clock required
>
> +Optional properties:
> +- dma_min_chan: the minimum number of DMA channel which begin to use
> + the default value is 0, but in some platform is
> + configured 1, like hi3660 platform
Can't this be implied by the compatible?
If not, needs vendor prefix and don't use '_' in property names.
Rob
next prev parent reply other threads:[~2018-07-03 18:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-22 3:24 [PATCH 0/3] k3dma: add support to reserved channels Guodong Xu
2018-06-22 3:24 ` [PATCH 1/3] dt-bindings: k3dma: add optional property dma_min_chan Guodong Xu
2018-06-28 6:00 ` Vinod
2018-07-03 18:54 ` Rob Herring [this message]
2018-07-04 1:14 ` Guodong Xu
2018-07-06 3:17 ` Guodong Xu
2018-06-22 3:24 ` [PATCH 2/3] k3dma: add support to reserved minimum channels Guodong Xu
2018-06-28 6:02 ` Vinod
2018-07-06 3:05 ` Guodong Xu
2018-07-06 6:09 ` Vinod
2018-06-22 3:24 ` [PATCH 3/3] k3dma: delete axi_config Guodong Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180703185442.GA18008@rob-hp-laptop \
--to=robh@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=fengbaopeng@hisilicon.com \
--cc=guodong.xu@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liyu65@hisilicon.com \
--cc=mark.rutland@arm.com \
--cc=sunliang10@huawei.com \
--cc=suzhuangluan@hisilicon.com \
--cc=vkoul@kernel.org \
--cc=xuezhiliang@hisilicon.com \
--cc=xuhongtao8@hisilicon.com \
--cc=xupeng7@huawei.com \
--cc=zhongkaihua@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).