From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Anna-Maria Gleixner <anna-maria@linutronix.de>,
Shaohua Li <shli@kernel.org>,
linux-raid@vger.kernel.org,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: [PATCH 1/6] drivers/md/raid5: Use irqsave variant of atomic_dec_and_lock()
Date: Tue, 3 Jul 2018 22:01:36 +0200 [thread overview]
Message-ID: <20180703200141.28415-2-bigeasy@linutronix.de> (raw)
In-Reply-To: <20180703200141.28415-1-bigeasy@linutronix.de>
From: Anna-Maria Gleixner <anna-maria@linutronix.de>
The irqsave variant of atomic_dec_and_lock handles irqsave/restore when
taking/releasing the spin lock. With this variant the call of
local_irq_save is no longer required.
Cc: Shaohua Li <shli@kernel.org>
Cc: linux-raid@vger.kernel.org
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
drivers/md/raid5.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index 2031506a0ecd..e933bff9459e 100644
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -409,16 +409,15 @@ void raid5_release_stripe(struct stripe_head *sh)
md_wakeup_thread(conf->mddev->thread);
return;
slow_path:
- local_irq_save(flags);
/* we are ok here if STRIPE_ON_RELEASE_LIST is set or not */
- if (atomic_dec_and_lock(&sh->count, &conf->device_lock)) {
+ if (atomic_dec_and_lock_irqsave(&sh->count, &conf->device_lock, flags)) {
INIT_LIST_HEAD(&list);
hash = sh->hash_lock_index;
do_release_stripe(conf, sh, &list);
spin_unlock(&conf->device_lock);
release_inactive_stripe_list(conf, &list, hash);
+ local_irq_restore(flags);
}
- local_irq_restore(flags);
}
static inline void remove_hash(struct stripe_head *sh)
--
2.18.0
next prev parent reply other threads:[~2018-07-03 20:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 20:01 [PATCH 0/6] use irqsafe variant of refcount_dec_and_lock() / atomic_dec_and_lock() Sebastian Andrzej Siewior
2018-07-03 20:01 ` Sebastian Andrzej Siewior [this message]
2018-07-16 12:27 ` [PATCH 1/6] drivers/md/raid5: Use irqsave variant of atomic_dec_and_lock() Sebastian Andrzej Siewior
2018-07-17 0:37 ` Shaohua Li
2018-07-18 10:57 ` Sebastian Andrzej Siewior
2018-07-19 2:44 ` Shaohua Li
2018-07-19 7:35 ` Sebastian Andrzej Siewior
2018-07-03 20:01 ` [PATCH 2/6] drivers/md/raid5: Do not disable irq on release_inactive_stripe_list() call Sebastian Andrzej Siewior
2018-07-20 8:29 ` Sebastian Andrzej Siewior
2018-07-03 20:01 ` [PATCH 3/6] bdi: Use refcount_t for reference counting instead atomic_t Sebastian Andrzej Siewior
2018-07-16 12:30 ` Sebastian Andrzej Siewior
2018-07-16 22:57 ` Andrew Morton
2018-07-17 15:56 ` Sebastian Andrzej Siewior
2018-07-03 20:01 ` [PATCH 4/6] bdi: Use irqsave variant of refcount_dec_and_lock() Sebastian Andrzej Siewior
2018-07-03 20:01 ` [PATCH 5/6] userns: Use refcount_t for reference counting instead atomic_t Sebastian Andrzej Siewior
2018-07-16 12:39 ` Sebastian Andrzej Siewior
2018-07-03 20:01 ` [PATCH 6/6] userns: Use irqsave variant of refcount_dec_and_lock() Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180703200141.28415-2-bigeasy@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=anna-maria@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=shli@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).