From: Jiri Olsa <jolsa@redhat.com>
To: Jack Henschel <jackdev@mailbox.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf parser: Improve error message for PMU address filters
Date: Wed, 4 Jul 2018 12:24:24 +0200 [thread overview]
Message-ID: <20180704102424.GA19164@krava> (raw)
In-Reply-To: <20180704095409.6109-1-jackdev@mailbox.org>
On Wed, Jul 04, 2018 at 11:54:09AM +0200, Jack Henschel wrote:
> This patch improves the error message of the perf events parser
> when the PMU hardware does not support address filters.
>
> Previously, the perf returned the following error:
> > --filter option should follow a -e tracepoint or HW tracer option
> This implies there is some syntax error present in the command line,
> which is not true. Rather, notify the user that the CPU does not have
> support for this feature.
>
> For example, Intel chips based on the Broadwell micro-archticture have
> the Intel PT PMU, but do not support address filtering.
looks ok, but please provide real examples of those error outputs in changelog
thanks,
jirka
>
> Signed-off-by: Jack Henschel <jackdev@mailbox.org>
> ---
> tools/perf/util/parse-events.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
> index 15eec49e71a1..f8cd3e7c9186 100644
> --- a/tools/perf/util/parse-events.c
> +++ b/tools/perf/util/parse-events.c
> @@ -1991,8 +1991,11 @@ static int set_filter(struct perf_evsel *evsel, const void *arg)
> int nr_addr_filters = 0;
> struct perf_pmu *pmu = NULL;
>
> - if (evsel == NULL)
> - goto err;
> + if (evsel == NULL) {
> + fprintf(stderr,
> + "--filter option should follow a -e tracepoint or HW tracer option\n");
> + return -1;
> + }
>
> if (evsel->attr.type == PERF_TYPE_TRACEPOINT) {
> if (perf_evsel__append_tp_filter(evsel, str) < 0) {
> @@ -2014,8 +2017,11 @@ static int set_filter(struct perf_evsel *evsel, const void *arg)
> perf_pmu__scan_file(pmu, "nr_addr_filters",
> "%d", &nr_addr_filters);
>
> - if (!nr_addr_filters)
> - goto err;
> + if (!nr_addr_filters) {
> + fprintf(stderr,
> + "This CPU does not support address filtering\n");
> + return -1;
> + }
>
> if (perf_evsel__append_addr_filter(evsel, str) < 0) {
> fprintf(stderr,
> @@ -2024,12 +2030,6 @@ static int set_filter(struct perf_evsel *evsel, const void *arg)
> }
>
> return 0;
> -
> -err:
> - fprintf(stderr,
> - "--filter option should follow a -e tracepoint or HW tracer option\n");
> -
> - return -1;
> }
>
> int parse_filter(const struct option *opt, const char *str,
> --
> 2.18.0
>
next prev parent reply other threads:[~2018-07-04 10:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 9:54 [PATCH] perf parser: Improve error message for PMU address filters Jack Henschel
2018-07-04 10:24 ` Jiri Olsa [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-09-05 9:08 Jack Henschel
2017-10-19 19:37 ` Jack Henschel
2017-10-19 19:57 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180704102424.GA19164@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jackdev@mailbox.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).