From: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
To: Enric Balletbo Serra <eballetbo@gmail.com>
Cc: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Michael Turquette" <mturquette@baylibre.com>,
sboyd@kernel.org, "Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Lee Jones" <lee.jones@linaro.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Matti Vaittinen" <mazziesaccount@gmail.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Sebastian Reichel" <sre@kernel.org>,
chenjh@rock-chips.com,
"Andrey Smirnov" <andrew.smirnov@gmail.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Kate Stewart" <kstewart@linuxfoundation.org>,
"Heiko Stübner" <heiko@sntech.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-clk@vger.kernel.org,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-input@vger.kernel.org, mikko.mutanen@fi.rohmeurope.com,
heikki.haikola@fi.rohmeurope.com
Subject: Re: [PATCH v7 1/4] mfd: bd71837: mfd driver for ROHM BD71837 PMIC
Date: Thu, 5 Jul 2018 10:56:50 +0300 [thread overview]
Message-ID: <20180705075650.GA7683@localhost.localdomain> (raw)
In-Reply-To: <CAFqH_50UshTTc0Cv0wBhUoPdm0jZVgcvRKr3qzb=M-jCcMhdtA@mail.gmail.com>
On Wed, Jul 04, 2018 at 06:57:39PM +0200, Enric Balletbo Serra wrote:
> Missatge de Dmitry Torokhov <dmitry.torokhov@gmail.com> del dia dc., 4
> de jul. 2018 a les 17:10:
> >
> > Hi Enric,
> >
> > On Tue, Jun 26, 2018 at 11:06:33AM +0200, Enric Balletbo Serra wrote:
> > > Hi Matti,
> > >
> > > Thanks for the patch, a few comments below, some are feedback I
> > > received when I sent some patches to this subsystem.
> > >
> > > Missatge de Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> del
> > > dia dt., 19 de juny 2018 a les 12:57:
> > > > +};
> > > > +
> > > > +/* bd71837 multi function cells */
> > > > +static struct mfd_cell bd71837_mfd_cells[] = {
> > > > + {
> > > > + .name = "bd71837-clk",
> > > > + }, {
> > > > + .name = "bd718xx-pwrkey",
> > > > + .resources = &irqs[0],
> > > > + .num_resources = ARRAY_SIZE(irqs),
> > > > + }, {
> > > > + .name = "bd71837-pmic",
> > > > + },
> > > nit: no comma at the end
> >
> > Actually, trailing comma is preferred on structures/arrays without
> > sentinels, because if one needs to add a new entry/new member, then in
> > the diff there will have only one new line added, instead of one line
> > being changed (adding now necessary comma) and one added.
> >
>
> Many thanks for sharing your knowledge! That looks to me a good
> reason.
So in this specific ecample leaving the comma does not help. The opening
brace for new array element would be added to same line where the comma
is, right? In any case - this was educating and makes perfect sense for
arrays with simple items. Thanks.
> Matti, I don't want to beat about the bush with these nitpicks. It is
> not my intention. So I'd say, do what the maintainer wants :)
>
No problem.
Br,
Matti Vaittinen
next prev parent reply other threads:[~2018-07-05 7:57 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 10:55 [PATCH v7 0/4] mfd/regulator/clk/input: bd71837: ROHM BD71837 PMIC driver Matti Vaittinen
2018-06-19 10:55 ` [PATCH v7 1/4] mfd: bd71837: mfd driver for ROHM BD71837 PMIC Matti Vaittinen
2018-06-26 9:06 ` Enric Balletbo Serra
2018-06-26 11:24 ` Matti Vaittinen
2018-06-26 11:40 ` Enric Balletbo Serra
2018-06-26 12:03 ` Matti Vaittinen
2018-06-26 14:24 ` Enric Balletbo Serra
2018-07-03 6:56 ` Lee Jones
2018-07-03 8:09 ` Enric Balletbo Serra
2018-07-03 6:53 ` Lee Jones
2018-07-04 14:56 ` Dmitry Torokhov
2018-07-04 16:57 ` Enric Balletbo Serra
2018-07-05 5:52 ` Lee Jones
2018-07-05 7:56 ` Matti Vaittinen [this message]
2018-07-06 6:38 ` Dmitry Torokhov
2018-07-06 7:05 ` Lee Jones
2018-07-06 7:49 ` Matti Vaittinen
2018-06-19 10:56 ` [PATCH v7 2/4] mfd: bd71837: Devicetree bindings " Matti Vaittinen
2018-06-19 10:56 ` [PATCH v7 3/4] clk: bd71837: Add driver for BD71837 PMIC clock Matti Vaittinen
2018-06-19 10:57 ` [PATCH v7 4/4] input/power: Add driver for BD71837/BD71847 PMIC power button Matti Vaittinen
2018-06-19 17:50 ` Dmitry Torokhov
2018-06-20 6:43 ` Matti Vaittinen
2018-06-21 10:25 ` Matti Vaittinen
2018-06-27 0:21 ` Dmitry Torokhov
2018-06-21 10:34 ` [PATCH v7 0/4] mfd/regulator/clk/input: bd71837: ROHM BD71837 PMIC driver Matti Vaittinen
2018-07-03 7:02 ` Lee Jones
2018-07-04 8:47 ` Matti Vaittinen
2018-07-04 9:21 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180705075650.GA7683@localhost.localdomain \
--to=matti.vaittinen@fi.rohmeurope.com \
--cc=andrew.smirnov@gmail.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=chenjh@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=eballetbo@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.haikola@fi.rohmeurope.com \
--cc=heiko@sntech.de \
--cc=kstewart@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mazziesaccount@gmail.com \
--cc=mikko.mutanen@fi.rohmeurope.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).