From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A7FAC3279B for ; Fri, 6 Jul 2018 07:03:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A8EC722564 for ; Fri, 6 Jul 2018 07:03:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="XfLrZ6S4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8EC722564 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753545AbeGFHDi (ORCPT ); Fri, 6 Jul 2018 03:03:38 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:56248 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753134AbeGFHDh (ORCPT ); Fri, 6 Jul 2018 03:03:37 -0400 Received: by mail-wm0-f65.google.com with SMTP id v16-v6so13790774wmv.5 for ; Fri, 06 Jul 2018 00:03:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=5bm8o7brhtSVC/LhoKUd4JeWYd/MlVlmybLqKOAtBzg=; b=XfLrZ6S4JcVCoXCKx3OIUgfp/GrTzUZY0vesfPiHpD2O7aWkt3gWDzs5WrBwi6VdV3 tiFdOrYypUOvmU42p2Bswzq6OpsoM0unWItlleAcA3BwZKpWQWQOPTOwBLQeJ91PCGqv BF97L8ia+r1UX8HGfa0w1YSPUIfgmv9w/cQrs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=5bm8o7brhtSVC/LhoKUd4JeWYd/MlVlmybLqKOAtBzg=; b=YkyGxsjpjn4weHWpod8UWNZkv01U+jjtIOAKthgs4uM3mHOAvnUfC6baV0sJdEjXlf u9VgH0kx00hyYgAdo9r20vP8ysjnWjXCIETkYEN/PC8ruO4ALNi2p0x6URpCcujjHhmW v/F4fm7c/EGe4MuOw6HvYSwHTEDkMzh/22PXnx4hG/LvaFqYampKdm0ovUn0Gzqupkd6 CbcBha0xq8r+gHgoA8RK6sFKC3a6hwvIEEzNGzmS6TReNqC1H3v+dcXxWbN2flV6CoJX sgaAO/wB6WhwCYFO69bnQ3biZbuyU70FqPraVpYeEjktsIe47KSlBTTNvoiLd7/Gh/gf N06w== X-Gm-Message-State: APt69E3b5YFdIPKQJ6LEp90zBfbU3UgbBT1Syzc3OmW12e7MXMWAjknS ic7mHurb0vKLMdq+EY9lyy1rLw== X-Google-Smtp-Source: AAOMgpehIL1zuSRR4mpvp9Euc+5PfFinqw/nVwhXe/PIpv/Zuen7C61QSd573Idph8GXGJ8y5Hx/wg== X-Received: by 2002:a1c:7d47:: with SMTP id y68-v6mr5369152wmc.62.1530860615815; Fri, 06 Jul 2018 00:03:35 -0700 (PDT) Received: from dell ([2.27.167.87]) by smtp.gmail.com with ESMTPSA id 185-v6sm15338893wmw.23.2018.07.06.00.03.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 06 Jul 2018 00:03:34 -0700 (PDT) Date: Fri, 6 Jul 2018 08:03:32 +0100 From: Lee Jones To: Jae Hyun Yoo Cc: Jason M Biils , Greg Kroah-Hartman , Philippe Ombredanne , Viresh Kumar , Vinod Koul , Takashi Iwai , Peter Rosin , David Kershner , Sagar Dharia , Uwe Kleine-Konig , Randy Dunlap , Thomas Gleixner , Philipp Zabel , Sanyog Kale , Cyrille Pitchen , Juergen Gross , linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, Fengguang Wu , Alan Cox , Andrew Lunn , Andy Shevchenko , Arnd Bergmann , Benjamin Herrenschmidt , Julia Cartwright Subject: Re: [PATCH linux-next v6 03/13] peci: Add support for PECI bus driver core Message-ID: <20180706070332.GV496@dell> References: <20180621193721.20588-1-jae.hyun.yoo@linux.intel.com> <20180621194014.20729-1-jae.hyun.yoo@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180621194014.20729-1-jae.hyun.yoo@linux.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 21 Jun 2018, Jae Hyun Yoo wrote: > This commit adds driver implementation for PECI bus core into linux > driver framework. > > Signed-off-by: Jae Hyun Yoo > Signed-off-by: Fengguang Wu > Reviewed-by: Haiyue Wang > Reviewed-by: James Feist > Reviewed-by: Vernon Mauery > Cc: Alan Cox > Cc: Andrew Lunn > Cc: Andy Shevchenko > Cc: Arnd Bergmann > Cc: Benjamin Herrenschmidt > Cc: Fengguang Wu > Cc: Greg KH > Cc: Jason M Biils > Cc: Julia Cartwright > --- > drivers/Kconfig | 2 + > drivers/Makefile | 1 + > drivers/peci/Kconfig | 12 + > drivers/peci/Makefile | 6 + > drivers/peci/peci-core.c | 1438 +++++++++++++++++++++++++++++++ > include/linux/peci.h | 104 +++ > include/uapi/linux/peci-ioctl.h | 265 ++++++ > 7 files changed, 1828 insertions(+) > create mode 100644 drivers/peci/Kconfig > create mode 100644 drivers/peci/Makefile > create mode 100644 drivers/peci/peci-core.c > create mode 100644 include/linux/peci.h > create mode 100644 include/uapi/linux/peci-ioctl.h I'm struggling to see the justification for adding an entirely new subsystem for what looks like a bespoke, and perhaps more damning, *proprietary* 1-wire interface. Especially one which has such limited use. Between yourself and the other silicon chip vendors there must be 100s of these knocking about. What makes this one special? Or even useful? Will there ever be more than a single source file in this directory? Don't get me wrong, I'm all for upstreaming code, but to create a new subsystem and bus for this kind of device seems very over the top. Since PECI's main purpose in life is Thermal Management, perhaps the whole thing should live in drivers/thermal or drivers/hwmon. I've also seen you reference this as a kind of BMC too, so maybe drivers/platform/x86 would also be a nice place for it to reside. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog