From: kbuild test robot <lkp@intel.com>
To: Roman Gushchin <guro@fb.com>
Cc: kbuild-all@01.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-team@fb.com, tj@kernel.org,
Roman Gushchin <guro@fb.com>, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>
Subject: Re: [PATCH v2 bpf-next 03/14] bpf: pass a pointer to a cgroup storage using pcpu variable
Date: Fri, 6 Jul 2018 15:50:48 +0800 [thread overview]
Message-ID: <201807061419.VGs3WwSs%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180705205139.3462-4-guro@fb.com>
[-- Attachment #1: Type: text/plain, Size: 10623 bytes --]
Hi Roman,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on bpf-next/master]
url: https://github.com/0day-ci/linux/commits/Roman-Gushchin/bpf-cgroup-local-storage/20180706-055938
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: powerpc-defconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=powerpc
All errors (new ones prefixed by >>):
In file included from include/linux/bpf-cgroup.h:6:0,
from kernel/bpf/local_storage.c:2:
include/linux/percpu-defs.h:49:34: error: 'PER_CPU_BASE_SECTION' undeclared here (not in a function); did you mean 'PER_CPU_FIRST_SECTION'?
__percpu __attribute__((section(PER_CPU_BASE_SECTION sec))) \
^
include/linux/percpu-defs.h:101:9: note: in expansion of macro '__PCPU_ATTRS'
extern __PCPU_ATTRS(sec) __typeof__(type) name
^~~~~~~~~~~~
include/linux/percpu-defs.h:113:2: note: in expansion of macro 'DECLARE_PER_CPU_SECTION'
DECLARE_PER_CPU_SECTION(type, name, "")
^~~~~~~~~~~~~~~~~~~~~~~
include/linux/bpf-cgroup.h:24:1: note: in expansion of macro 'DECLARE_PER_CPU'
DECLARE_PER_CPU(void*, bpf_cgroup_storage);
^~~~~~~~~~~~~~~
include/linux/percpu-defs.h:113:38: error: expected ')' before string constant
DECLARE_PER_CPU_SECTION(type, name, "")
^
include/linux/percpu-defs.h:49:55: note: in definition of macro '__PCPU_ATTRS'
__percpu __attribute__((section(PER_CPU_BASE_SECTION sec))) \
^~~
include/linux/percpu-defs.h:113:2: note: in expansion of macro 'DECLARE_PER_CPU_SECTION'
DECLARE_PER_CPU_SECTION(type, name, "")
^~~~~~~~~~~~~~~~~~~~~~~
include/linux/bpf-cgroup.h:24:1: note: in expansion of macro 'DECLARE_PER_CPU'
DECLARE_PER_CPU(void*, bpf_cgroup_storage);
^~~~~~~~~~~~~~~
include/linux/percpu-defs.h:49:59: error: expected identifier or '(' before ')' token
__percpu __attribute__((section(PER_CPU_BASE_SECTION sec))) \
^
include/linux/percpu-defs.h:101:9: note: in expansion of macro '__PCPU_ATTRS'
extern __PCPU_ATTRS(sec) __typeof__(type) name
^~~~~~~~~~~~
include/linux/percpu-defs.h:113:2: note: in expansion of macro 'DECLARE_PER_CPU_SECTION'
DECLARE_PER_CPU_SECTION(type, name, "")
^~~~~~~~~~~~~~~~~~~~~~~
include/linux/bpf-cgroup.h:24:1: note: in expansion of macro 'DECLARE_PER_CPU'
DECLARE_PER_CPU(void*, bpf_cgroup_storage);
^~~~~~~~~~~~~~~
include/linux/bpf-cgroup.h: In function 'bpf_cgroup_storage_set':
>> include/linux/bpf-cgroup.h:110:17: error: 'bpf_cgroup_storage' undeclared (first use in this function)
this_cpu_write(bpf_cgroup_storage, &buf->data[0]);
^
include/linux/percpu-defs.h:221:47: note: in definition of macro '__verify_pcpu_ptr'
const void __percpu *__vpp_verify = (typeof((ptr) + 0))NULL; \
^~~
include/linux/percpu-defs.h:510:34: note: in expansion of macro '__pcpu_size_call'
#define this_cpu_write(pcp, val) __pcpu_size_call(this_cpu_write_, pcp, val)
^~~~~~~~~~~~~~~~
include/linux/bpf-cgroup.h:110:2: note: in expansion of macro 'this_cpu_write'
this_cpu_write(bpf_cgroup_storage, &buf->data[0]);
^~~~~~~~~~~~~~
include/linux/bpf-cgroup.h:110:17: note: each undeclared identifier is reported only once for each function it appears in
this_cpu_write(bpf_cgroup_storage, &buf->data[0]);
^
include/linux/percpu-defs.h:221:47: note: in definition of macro '__verify_pcpu_ptr'
const void __percpu *__vpp_verify = (typeof((ptr) + 0))NULL; \
^~~
include/linux/percpu-defs.h:510:34: note: in expansion of macro '__pcpu_size_call'
#define this_cpu_write(pcp, val) __pcpu_size_call(this_cpu_write_, pcp, val)
^~~~~~~~~~~~~~~~
include/linux/bpf-cgroup.h:110:2: note: in expansion of macro 'this_cpu_write'
this_cpu_write(bpf_cgroup_storage, &buf->data[0]);
^~~~~~~~~~~~~~
include/linux/percpu-defs.h:510:51: error: implicit declaration of function 'this_cpu_write_1'; did you mean 'this_cpu_write'? [-Werror=implicit-function-declaration]
#define this_cpu_write(pcp, val) __pcpu_size_call(this_cpu_write_, pcp, val)
^
include/linux/percpu-defs.h:379:11: note: in definition of macro '__pcpu_size_call'
case 1: stem##1(variable, __VA_ARGS__);break; \
^~~~
include/linux/bpf-cgroup.h:110:2: note: in expansion of macro 'this_cpu_write'
this_cpu_write(bpf_cgroup_storage, &buf->data[0]);
^~~~~~~~~~~~~~
include/linux/percpu-defs.h:510:51: error: implicit declaration of function 'this_cpu_write_2'; did you mean 'this_cpu_write'? [-Werror=implicit-function-declaration]
#define this_cpu_write(pcp, val) __pcpu_size_call(this_cpu_write_, pcp, val)
^
include/linux/percpu-defs.h:380:11: note: in definition of macro '__pcpu_size_call'
case 2: stem##2(variable, __VA_ARGS__);break; \
^~~~
include/linux/bpf-cgroup.h:110:2: note: in expansion of macro 'this_cpu_write'
this_cpu_write(bpf_cgroup_storage, &buf->data[0]);
^~~~~~~~~~~~~~
include/linux/percpu-defs.h:510:51: error: implicit declaration of function 'this_cpu_write_4'; did you mean 'this_cpu_write'? [-Werror=implicit-function-declaration]
#define this_cpu_write(pcp, val) __pcpu_size_call(this_cpu_write_, pcp, val)
^
include/linux/percpu-defs.h:381:11: note: in definition of macro '__pcpu_size_call'
case 4: stem##4(variable, __VA_ARGS__);break; \
^~~~
include/linux/bpf-cgroup.h:110:2: note: in expansion of macro 'this_cpu_write'
this_cpu_write(bpf_cgroup_storage, &buf->data[0]);
^~~~~~~~~~~~~~
include/linux/percpu-defs.h:510:51: error: implicit declaration of function 'this_cpu_write_8'; did you mean 'this_cpu_write'? [-Werror=implicit-function-declaration]
#define this_cpu_write(pcp, val) __pcpu_size_call(this_cpu_write_, pcp, val)
^
include/linux/percpu-defs.h:382:11: note: in definition of macro '__pcpu_size_call'
case 8: stem##8(variable, __VA_ARGS__);break; \
^~~~
include/linux/bpf-cgroup.h:110:2: note: in expansion of macro 'this_cpu_write'
this_cpu_write(bpf_cgroup_storage, &buf->data[0]);
^~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/bpf_cgroup_storage +110 include/linux/bpf-cgroup.h
23
> 24 DECLARE_PER_CPU(void*, bpf_cgroup_storage);
25
26 struct bpf_cgroup_storage_map;
27
28 struct bpf_storage_buffer {
29 struct rcu_head rcu;
30 char data[0];
31 };
32
33 struct bpf_cgroup_storage {
34 struct bpf_storage_buffer *buf;
35 struct bpf_cgroup_storage_map *map;
36 struct bpf_cgroup_storage_key key;
37 struct list_head list;
38 struct rb_node node;
39 struct rcu_head rcu;
40 };
41
42 struct bpf_prog_list {
43 struct list_head node;
44 struct bpf_prog *prog;
45 };
46
47 struct bpf_prog_array;
48
49 struct cgroup_bpf {
50 /* array of effective progs in this cgroup */
51 struct bpf_prog_array __rcu *effective[MAX_BPF_ATTACH_TYPE];
52
53 /* attached progs to this cgroup and attach flags
54 * when flags == 0 or BPF_F_ALLOW_OVERRIDE the progs list will
55 * have either zero or one element
56 * when BPF_F_ALLOW_MULTI the list can have up to BPF_CGROUP_MAX_PROGS
57 */
58 struct list_head progs[MAX_BPF_ATTACH_TYPE];
59 u32 flags[MAX_BPF_ATTACH_TYPE];
60
61 /* temp storage for effective prog array used by prog_attach/detach */
62 struct bpf_prog_array __rcu *inactive;
63 };
64
65 void cgroup_bpf_put(struct cgroup *cgrp);
66 int cgroup_bpf_inherit(struct cgroup *cgrp);
67
68 int __cgroup_bpf_attach(struct cgroup *cgrp, struct bpf_prog *prog,
69 enum bpf_attach_type type, u32 flags);
70 int __cgroup_bpf_detach(struct cgroup *cgrp, struct bpf_prog *prog,
71 enum bpf_attach_type type, u32 flags);
72 int __cgroup_bpf_query(struct cgroup *cgrp, const union bpf_attr *attr,
73 union bpf_attr __user *uattr);
74
75 /* Wrapper for __cgroup_bpf_*() protected by cgroup_mutex */
76 int cgroup_bpf_attach(struct cgroup *cgrp, struct bpf_prog *prog,
77 enum bpf_attach_type type, u32 flags);
78 int cgroup_bpf_detach(struct cgroup *cgrp, struct bpf_prog *prog,
79 enum bpf_attach_type type, u32 flags);
80 int cgroup_bpf_query(struct cgroup *cgrp, const union bpf_attr *attr,
81 union bpf_attr __user *uattr);
82
83 int __cgroup_bpf_run_filter_skb(struct sock *sk,
84 struct sk_buff *skb,
85 enum bpf_attach_type type);
86
87 int __cgroup_bpf_run_filter_sk(struct sock *sk,
88 enum bpf_attach_type type);
89
90 int __cgroup_bpf_run_filter_sock_addr(struct sock *sk,
91 struct sockaddr *uaddr,
92 enum bpf_attach_type type,
93 void *t_ctx);
94
95 int __cgroup_bpf_run_filter_sock_ops(struct sock *sk,
96 struct bpf_sock_ops_kern *sock_ops,
97 enum bpf_attach_type type);
98
99 int __cgroup_bpf_check_dev_permission(short dev_type, u32 major, u32 minor,
100 short access, enum bpf_attach_type type);
101
102 static inline void bpf_cgroup_storage_set(struct bpf_cgroup_storage *storage)
103 {
104 struct bpf_storage_buffer *buf;
105
106 if (!storage)
107 return;
108
109 buf = rcu_dereference(storage->buf);
> 110 this_cpu_write(bpf_cgroup_storage, &buf->data[0]);
111 }
112
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 23809 bytes --]
next prev parent reply other threads:[~2018-07-06 7:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 20:51 [PATCH v2 bpf-next 00/14] bpf: cgroup local storage Roman Gushchin
2018-07-05 20:51 ` [PATCH v2 bpf-next 01/14] bpf: add ability to charge bpf maps memory dynamically Roman Gushchin
2018-07-05 20:51 ` [PATCH v2 bpf-next 02/14] bpf: introduce cgroup storage maps Roman Gushchin
2018-07-06 14:42 ` kbuild test robot
2018-07-06 21:52 ` Roman Gushchin
2018-07-07 22:35 ` Alexei Starovoitov
2018-07-09 8:37 ` Daniel Borkmann
2018-07-09 18:53 ` Roman Gushchin
2018-07-05 20:51 ` [PATCH v2 bpf-next 03/14] bpf: pass a pointer to a cgroup storage using pcpu variable Roman Gushchin
2018-07-06 7:50 ` kbuild test robot [this message]
2018-07-06 9:25 ` kbuild test robot
2018-07-05 20:51 ` [PATCH v2 bpf-next 04/14] bpf: allocate cgroup storage entries on attaching bpf programs Roman Gushchin
2018-07-05 20:51 ` [PATCH v2 bpf-next 05/14] bpf: extend bpf_prog_array to store pointers to the cgroup storage Roman Gushchin
2018-07-06 7:50 ` kbuild test robot
2018-07-05 20:51 ` [PATCH v2 bpf-next 06/14] bpf/verifier: introduce BPF_PTR_TO_MAP_VALUE Roman Gushchin
2018-07-05 20:51 ` [PATCH v2 bpf-next 07/14] bpf: don't allow create maps of cgroup local storages Roman Gushchin
2018-07-05 20:51 ` [PATCH v2 bpf-next 08/14] bpf: introduce the bpf_get_local_storage() helper function Roman Gushchin
2018-07-05 20:51 ` [PATCH v2 bpf-next 09/14] bpf: sync bpf.h to tools/ Roman Gushchin
2018-07-05 20:51 ` [PATCH v2 bpf-next 10/14] bpftool: add support for CGROUP_STORAGE maps Roman Gushchin
2018-07-05 20:51 ` [PATCH v2 bpf-next 11/14] bpf/test_run: support cgroup local storage Roman Gushchin
2018-07-05 20:51 ` [PATCH v2 bpf-next 12/14] selftests/bpf: add verifier cgroup storage tests Roman Gushchin
2018-07-05 20:51 ` [PATCH v2 bpf-next 13/14] selftests/bpf: add a cgroup storage test Roman Gushchin
2018-07-05 20:51 ` [PATCH v2 bpf-next 14/14] samples/bpf: extend test_cgrp2_attach2 test to use cgroup storage Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201807061419.VGs3WwSs%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=guro@fb.com \
--cc=kbuild-all@01.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).