linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: harini.katakam@xilinx.com
Cc: nicolas.ferre@microchip.com, claudiu.beznea@microchip.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	michal.simek@xilinx.com, harinikatakamlinux@gmail.com
Subject: Re: [PATCH v2 2/2] net: macb: Allocate valid memory for TX and RX BD prefetch
Date: Sat, 07 Jul 2018 20:55:21 +0900 (KST)	[thread overview]
Message-ID: <20180707.205521.189537026947491605.davem@davemloft.net> (raw)
In-Reply-To: <1530859738-11802-2-git-send-email-harini.katakam@xilinx.com>

From: Harini Katakam <harini.katakam@xilinx.com>
Date: Fri, 6 Jul 2018 12:18:58 +0530

> GEM version in ZynqMP and most versions greater than r1p07 supports
> TX and RX BD prefetch. The number of BDs that can be prefetched is a
> HW configurable parameter. For ZynqMP, this parameter is 4.
> 
> When GEM DMA is accessing the last BD in the ring, even before the
> BD is processed and the WRAP bit is noticed, it will have prefetched
> BDs outside the BD ring. These will not be processed but it is
> necessary to have accessible memory after the last BD. Especially
> in cases where SMMU is used, memory locations immediately after the
> last BD may not have translation tables triggering HRESP errors. Hence
> always allocate extra BDs to accommodate for prefetch.
> The value of tx/rx bd prefetch for any given SoC version is:
> 2 ^ (corresponding field in design config 10 register).
> (value of this field >= 1)
> 
> Added a capability flag so that older IP versions that do not have
> DCFG10 or this prefetch capability are not affected.
> 
> Signed-off-by: Harini Katakam <harini.katakam@xilinx.com>
> Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>

Applied.

  reply	other threads:[~2018-07-07 11:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-06  6:48 [PATCH v2 1/2] net: macb: Free RX ring for all queues Harini Katakam
2018-07-06  6:48 ` [PATCH v2 2/2] net: macb: Allocate valid memory for TX and RX BD prefetch Harini Katakam
2018-07-07 11:55   ` David Miller [this message]
2018-07-07 11:55 ` [PATCH v2 1/2] net: macb: Free RX ring for all queues David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180707.205521.189537026947491605.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=claudiu.beznea@microchip.com \
    --cc=harini.katakam@xilinx.com \
    --cc=harinikatakamlinux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.ferre@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).