From: Vinod <vkoul@kernel.org>
To: Timur Tabi <timur@kernel.org>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-arm-msm@vger.kernel.org, Stephen Boyd <swboyd@chromium.org>,
Jeffrey Hugo <jhugo@codeaurora.org>
Subject: Re: [PATCH v4 6/6] crypto: qcom: Add ACPI support
Date: Mon, 9 Jul 2018 11:31:57 +0530 [thread overview]
Message-ID: <20180709060157.GZ22377@vkoul-mobl> (raw)
In-Reply-To: <38f34817-ff86-06b7-4aab-a009c353a6db@kernel.org>
On 07-07-18, 13:05, Timur Tabi wrote:
> On 7/5/18 1:07 AM, Vinod wrote:
> > Yes we can add driver data in ACPI ID as well so code can be:
> >
> > if (!has_acpi_companion(&pdev->dev)) {
> > rng->clk = devm_clk_get(&pdev->dev, "core");
> > if (IS_ERR(rng->clk))
> > return PTR_ERR(rng->clk);
> > }
> > rng->skip_init = device_get_match_data(&pdev->dev);
> >
> > Looks much neater.
>
> Yeah, I like it.
>
> > I will wait for feedback on other patches before updating this.
>
> Jeff said it works, so I guess v5 will be good to go.
Yes posting that right now. It would be great if you folks can test
again on ACPI systems
Thanks
--
~Vinod
next prev parent reply other threads:[~2018-07-09 6:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 11:44 [PATCH v4 0/6] crypto: Add Qcom PRNG support Vinod Koul
2018-07-04 11:44 ` [PATCH v4 1/6] hwrng: remove msm hw_random driver Vinod Koul
2018-07-04 11:44 ` [PATCH v4 2/6] dt-bindings: crypto: Move prng binding to crypto Vinod Koul
2018-07-04 11:44 ` [PATCH v4 3/6] crypto: Add Qcom prng driver Vinod Koul
2018-07-04 11:44 ` [PATCH v4 4/6] dt-bindings: crypto: Add new compatible qcom,prng-ee Vinod Koul
2018-07-04 11:44 ` [PATCH v4 5/6] crypto: qcom: Add support for prng-ee Vinod Koul
2018-07-04 11:44 ` [PATCH v4 6/6] crypto: qcom: Add ACPI support Vinod Koul
2018-07-04 14:46 ` Timur Tabi
2018-07-05 6:07 ` Vinod
2018-07-05 12:23 ` Timur Tabi
2018-07-05 13:24 ` Vinod
2018-07-07 18:05 ` Timur Tabi
2018-07-09 6:01 ` Vinod [this message]
2018-07-09 14:52 ` Jeffrey Hugo
2018-07-05 19:51 ` Jeffrey Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180709060157.GZ22377@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=swboyd@chromium.org \
--cc=timur@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).