From: Jiri Olsa <jolsa@redhat.com>
To: Sandipan Das <sandipan@linux.ibm.com>,
Milian Wolff <milian.wolff@kdab.com>
Cc: acme@kernel.org, linux-kernel@vger.kernel.org,
namhyung@kernel.org, ravi.bangoria@linux.ibm.com,
naveen.n.rao@linux.vnet.ibm.com
Subject: Re: [PATCH] perf script: Show correct offsets for DWARF-based unwinding
Date: Mon, 9 Jul 2018 16:25:07 +0200 [thread overview]
Message-ID: <20180709142507.GA7917@krava> (raw)
In-Reply-To: <20180703120555.32971-1-sandipan@linux.ibm.com>
On Tue, Jul 03, 2018 at 05:35:55PM +0530, Sandipan Das wrote:
SNIP
>
> After:
>
> # perf report --stdio --no-children -s sym,srcline -g address
>
> # Samples: 1 of event 'probe_libc:inet_pton'
> # Event count (approx.): 1
> #
> # Overhead Symbol Source:Line
> # ........ .................... ...........
> #
> 100.00% [.] __GI___inet_pton inet_pton.c
> |
> ---gaih_inet.constprop.7 getaddrinfo.c:537
> getaddrinfo getaddrinfo.c:2304
> main ping.c:519
> generic_start_main.isra.0 libc-start.c:308
> __libc_start_main libc-start.c:102
> ...
>
> # perf script -F comm,ip,sym,symoff,srcline,dso
>
> ping
> 7fffb38aaf28 __GI___inet_pton+0x8 (/usr/lib64/libc-2.26.so)
> inet_pton.c:68
> 7fffb385fa53 gaih_inet.constprop.7+0xf43 (/usr/lib64/libc-2.26.so)
> getaddrinfo.c:537
> 7fffb38605b3 getaddrinfo+0x163 (/usr/lib64/libc-2.26.so)
> getaddrinfo.c:2304
> 130782d6f main+0x3df (/usr/bin/ping)
> ping.c:519
> 7fffb377369f generic_start_main.isra.0+0x13f (/usr/lib64/libc-2.26.so)
> libc-start.c:308
> 7fffb3773897 __libc_start_main+0xb7 (/usr/lib64/libc-2.26.so)
> libc-start.c:102
>
> Fixes: 67540759151a ("perf unwind: Use addr_location::addr instead of ip for entries")
> Signed-off-by: Sandipan Das <sandipan@linux.ibm.com>
looks good to me, Milian?
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
next prev parent reply other threads:[~2018-07-09 14:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 12:05 [PATCH] perf script: Show correct offsets for DWARF-based unwinding Sandipan Das
2018-07-09 14:25 ` Jiri Olsa [this message]
2018-07-25 18:23 ` Milian Wolff
2018-07-25 20:49 ` [tip:perf/core] " tip-bot for Sandipan Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180709142507.GA7917@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=milian.wolff@kdab.com \
--cc=namhyung@kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=ravi.bangoria@linux.ibm.com \
--cc=sandipan@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).